From: Hans Verkuil <hverkuil@xs4all.nl>
To: Antonio Ospite <ao2@ao2.it>, linux-media@vger.kernel.org
Subject: Re: [RFC PATCH 0/5] v4l2-ctl: list controls values in a machine-readable format
Date: Mon, 7 Jan 2019 11:21:53 +0100 [thread overview]
Message-ID: <27028bd5-c188-1afa-47bc-bd05ac8ecd59@xs4all.nl> (raw)
In-Reply-To: <20190103180102.12282-1-ao2@ao2.it>
On 01/03/2019 07:00 PM, Antonio Ospite wrote:
> Hi,
>
> here is an experiment about listing controls values with v4l2-ctl in
> a way that makes it more easy to reload them, I would use something like
> that for https://git.ao2.it/v4l2-persistent-settings.git/
>
> Patches 1 and 2 are just warm-up patches to get me familiar again with
> the v4l2-ctrl codebase, patch 2 is a small preparatory cleanup, and
> patches 4 and 5 showcase the idea.
>
> Thanks,
> Antonio
>
> Antonio Ospite (5):
> v4l2-ctl: list controls with menus when OptAll is specified
> v4l2-ctl: list once when both OptListCtrls and OptListCtrlsMenus are
> there
I merged these first two patches.
> v4l2-ctl: use a dedicated function to print the control class name
> v4l2-ctl: abstract the mechanism used to print the list of controls
> v4l2-ctl: add an option to list controls in a machine-readable format
The others need more work, see my review of the last patch.
Thanks for working on this!
Regards,
Hans
>
> utils/v4l2-ctl/v4l2-ctl-common.cpp | 95 +++++++++++++++++++++++++-----
> utils/v4l2-ctl/v4l2-ctl.1.in | 4 ++
> utils/v4l2-ctl/v4l2-ctl.cpp | 3 +-
> utils/v4l2-ctl/v4l2-ctl.h | 1 +
> 4 files changed, 88 insertions(+), 15 deletions(-)
>
prev parent reply other threads:[~2019-01-07 10:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-24 17:52 [v4l-utils] Add options to v4l2-ctrl to save/load settings to/from a file Antonio Ospite
2019-01-03 18:00 ` [RFC PATCH 0/5] v4l2-ctl: list controls values in a machine-readable format Antonio Ospite
2019-01-03 18:00 ` [RFC PATCH 1/5] v4l2-ctl: list controls with menus when OptAll is specified Antonio Ospite
2019-01-03 18:00 ` [RFC PATCH 2/5] v4l2-ctl: list once when both OptListCtrls and OptListCtrlsMenus are there Antonio Ospite
2019-01-03 18:01 ` [RFC PATCH 3/5] v4l2-ctl: use a dedicated function to print the control class name Antonio Ospite
2019-01-03 18:01 ` [RFC PATCH 4/5] v4l2-ctl: abstract the mechanism used to print the list of controls Antonio Ospite
2019-01-03 18:01 ` [RFC PATCH 5/5] v4l2-ctl: add an option to list controls in a machine-readable format Antonio Ospite
2019-01-07 10:18 ` Hans Verkuil
2019-01-09 21:15 ` Antonio Ospite
2019-01-10 12:05 ` Hans Verkuil
2019-01-07 10:21 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27028bd5-c188-1afa-47bc-bd05ac8ecd59@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=ao2@ao2.it \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).