From: Ezequiel Garcia <ezequiel@collabora.com>
To: Helen Koike <helen.koike@collabora.com>,
devicetree@vger.kernel.org, linux-media@vger.kernel.org,
linux-rockchip@lists.infradead.org,
Heiko Stuebner <heiko@sntech.de>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
robh+dt@kernel.org, heiko@sntech.de, hverkuil-cisco@xs4all.nl,
kernel@collabora.com, dafna.hirschfeld@collabora.com,
mark.rutland@arm.com, karthik.poduval@gmail.com,
jbx6244@gmail.com, kishon@ti.com
Subject: Re: [PATCH v2 8/9] arm64: dts: rockchip: add rx0 mipi-phy for rk3399
Date: Sat, 09 May 2020 09:53:53 -0300 [thread overview]
Message-ID: <9fdceef69a390235225a8fd08f89f67be9c5c920.camel@collabora.com> (raw)
In-Reply-To: <20200403161538.1375908-9-helen.koike@collabora.com>
Hi Heiko,
On Fri, 2020-04-03 at 13:15 -0300, Helen Koike wrote:
> From: Shunqian Zheng <zhengsq@rock-chips.com>
>
> Designware MIPI D-PHY, used for ISP0 in rk3399.
>
> Verified with:
> make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml
>
> Signed-off-by: Shunqian Zheng <zhengsq@rock-chips.com>
> Signed-off-by: Jacob Chen <jacob2.chen@rock-chips.com>
> Signed-off-by: Helen Koike <helen.koike@collabora.com>
>
> ---
>
> Changes in v2:
> - fix alignment of clocks
>
> V1:
> This patchset came from the original ISP series from Rockchip:
>
> https://patchwork.kernel.org/patch/10267409/
>
Can you take the devicetree changes (patches 8 and 9) ?
Thanks,
Ezequiel
> The only difference is:
> - add phy-cells
> - update compatible to "rockchip,rk3399-mipi-dphy-rx0"
> - commit message
> ---
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index 33cc21fcf4c10..6b3380b10e596 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -1394,6 +1394,17 @@ io_domains: io-domains {
> status = "disabled";
> };
>
> + mipi_dphy_rx0: mipi-dphy-rx0 {
> + compatible = "rockchip,rk3399-mipi-dphy-rx0";
> + clocks = <&cru SCLK_MIPIDPHY_REF>,
> + <&cru SCLK_DPHY_RX0_CFG>,
> + <&cru PCLK_VIO_GRF>;
> + clock-names = "dphy-ref", "dphy-cfg", "grf";
> + power-domains = <&power RK3399_PD_VIO>;
> + #phy-cells = <0>;
> + status = "disabled";
> + };
> +
> u2phy0: usb2-phy@e450 {
> compatible = "rockchip,rk3399-usb2phy";
> reg = <0xe450 0x10>;
> --
> 2.26.0
>
>
next prev parent reply other threads:[~2020-05-09 12:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 16:15 [PATCH v2 0/9] move Rockchip ISP bindings out of staging / add ISP DT nodes for RK3399 Helen Koike
2020-04-03 16:15 ` [PATCH v2 1/9] media: staging: dt-bindings: rkisp1: add missing required nodes Helen Koike
2020-04-03 16:15 ` [PATCH v2 2/9] media: staging: dt-bindings: rkisp1: add required items in i2c example Helen Koike
2020-04-03 16:15 ` [PATCH v2 3/9] media: staging: dt-bindings: rkisp1: re-order properties Helen Koike
2020-04-03 16:15 ` [PATCH v2 4/9] media: staging: dt-bindings: phy-rockchip-dphy-rx0: remove non-used reg property Helen Koike
2020-04-03 16:15 ` [PATCH v2 5/9] dt-bindings: phy: phy-rockchip-dphy-rx0: move rockchip dphy rx0 bindings out of staging Helen Koike
2020-04-14 18:08 ` Rob Herring
2020-04-03 16:15 ` [PATCH v2 6/9] dt-bindings: media: rkisp1: move rockchip-isp1 " Helen Koike
2020-04-14 18:08 ` Rob Herring
2020-04-23 12:36 ` Johan Jonker
2020-04-23 13:33 ` Johan Jonker
2020-04-03 16:15 ` [PATCH v2 7/9] media: MAINTAINERS: rkisp1: add path to dt-bindings Helen Koike
2020-04-17 7:18 ` Hans Verkuil
2020-04-17 7:30 ` Joe Perches
2020-05-09 12:51 ` Ezequiel Garcia
2020-04-23 12:48 ` Johan Jonker
2020-04-03 16:15 ` [PATCH v2 8/9] arm64: dts: rockchip: add rx0 mipi-phy for rk3399 Helen Koike
2020-05-09 12:53 ` Ezequiel Garcia [this message]
2020-04-03 16:15 ` [PATCH v2 9/9] arm64: dts: rockchip: add isp0 node " Helen Koike
2020-07-01 12:31 ` [PATCH v2 0/9] move Rockchip ISP bindings out of staging / add ISP DT nodes for RK3399 Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fdceef69a390235225a8fd08f89f67be9c5c920.camel@collabora.com \
--to=ezequiel@collabora.com \
--cc=dafna.hirschfeld@collabora.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=helen.koike@collabora.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jbx6244@gmail.com \
--cc=karthik.poduval@gmail.com \
--cc=kernel@collabora.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).