From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Jacopo Mondi <jacopo@jmondi.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Steve Longerbeam <slongerbeam@gmail.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-media <linux-media@vger.kernel.org>,
Hugues Fruchet <hugues.fruchet@st.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Biju Das <biju.das.jz@bp.renesas.com>
Subject: Re: [PATCH 1/2] media: i2c: ov5640: Enable data pins on startup for DVP mode
Date: Sat, 1 Aug 2020 09:46:22 +0100 [thread overview]
Message-ID: <CA+V-a8tOMWKAmJU3sGJn6ieLN3FAQQvpVXwd0h0AFHVFGzZ+xg@mail.gmail.com> (raw)
In-Reply-To: <20200731152744.GI6218@pendragon.ideasonboard.com>
Hi Laurent,
Thank you for the review.
On Fri, Jul 31, 2020 at 4:27 PM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hi Prabhakar,
>
> Thank you for the patch.
>
> On Fri, Jul 31, 2020 at 10:24:46AM +0100, Lad Prabhakar wrote:
<snip>
> > + * - 6: VSYNC output enable
> > + * - 5: HREF output enable
> > + * - 4: PCLK output enable
> > + * - [3:0]: D[9:6] output enable
> > + */
> > + ret = ov5640_write_reg(sensor, OV5640_REG_PAD_OUTPUT_ENABLE01, 0x7f);
> > + if (ret)
> > + goto power_off;
> >
> > - /* Give lanes some time to coax into LP11 state. */
> > - usleep_range(500, 1000);
> > + /*
> > + * enable D[5:0] DVP data lines
> > + *
> > + * PAD OUTPUT ENABLE 02
> > + * - [7:2]: D[5:0] output enable
> > + */
> > + ret = ov5640_write_reg(sensor, OV5640_REG_PAD_OUTPUT_ENABLE02, 0xfc);
> > + if (ret)
> > + goto power_off;
> > + }
>
> I'd split this to two separate functions, one for CSI-2, one for
> parallel, as this is getting difficult to read.
>
Sure I'll split this up in v2..
Cheers,
Prabhakar
> >
> > } else {
> > if (sensor->ep.bus_type == V4L2_MBUS_CSI2_DPHY) {
>
> --
> Regards,
>
> Laurent Pinchart
next prev parent reply other threads:[~2020-08-01 8:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 9:24 [PATCH 0/2] media: ov5640 feature enhancement and fixes Lad Prabhakar
2020-07-31 9:24 ` [PATCH 1/2] media: i2c: ov5640: Enable data pins on startup for DVP mode Lad Prabhakar
2020-07-31 13:03 ` Sakari Ailus
2020-07-31 13:18 ` Lad, Prabhakar
2020-07-31 15:19 ` Sakari Ailus
2020-07-31 15:23 ` Lad, Prabhakar
2020-07-31 15:31 ` Laurent Pinchart
2020-08-01 8:51 ` Lad, Prabhakar
2020-07-31 15:27 ` Laurent Pinchart
2020-08-01 8:46 ` Lad, Prabhakar [this message]
2020-07-31 9:24 ` [PATCH 2/2] media: i2c: ov5640: Add support for BT656 mode Lad Prabhakar
2020-07-31 15:23 ` Sakari Ailus
2020-07-31 15:28 ` Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+V-a8tOMWKAmJU3sGJn6ieLN3FAQQvpVXwd0h0AFHVFGzZ+xg@mail.gmail.com \
--to=prabhakar.csengg@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=hugues.fruchet@st.com \
--cc=jacopo@jmondi.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=sakari.ailus@linux.intel.com \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).