From: Chen-Yu Tsai <wens@csie.org>
To: "Jernej Škrabec" <jernej.skrabec@gmail.com>
Cc: Maxime Ripard <mripard@kernel.org>,
linux-sunxi <linux-sunxi@googlegroups.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mike Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
Jernej Skrabec <jernej.skrabec@siol.net>
Subject: Re: [linux-sunxi] [PATCH 0/8] media: sunxi: Add DE2 rotate driver
Date: Thu, 12 Mar 2020 13:31:28 +0800 [thread overview]
Message-ID: <CAGb2v647N4oSf=txbCfc05L6j8_U4bBtfa+XxYX6ZUMmrYbs0Q@mail.gmail.com> (raw)
In-Reply-To: <4206703.LvFx2qVVIh@jernej-laptop>
On Wed, Feb 12, 2020 at 3:13 AM Jernej Škrabec <jernej.skrabec@gmail.com> wrote:
>
> Dne sobota, 25. januar 2020 ob 00:20:06 CET je Jernej Skrabec napisal(a):
> > Some of Allwinner SoCs like A83T and A64 SoCs contain DE2 rotate core
> > which can flip image horizontal and vertical and rotate it in 90 deg.
> > steps. It support a lot of output formats, but a bit less capture
> > formats. All YUV input formats get converted to yuv420p, while RGB
> > formats are preserved.
> >
> > Patches 1-2 fix few issues with DE2 clocks.
> >
> > Patches 3-4 fix register range of DE2 clocks (it would overlap with
> > rotate driver)
> >
> > Patches 5-8 provide binding, implement driver and add nodes.
> >
> > v4l2-compliance SHA: ec55a961487b449bedbe07650674b4965814cf07, 32 bits,
> > 32-bit time_t
> >
> > Compliance test for sun8i-rotate device /dev/video0:
> >
> > Driver Info:
> > Driver name : sun8i-rotate
> > Card type : sun8i-rotate
> > Bus info : platform:sun8i-rotate
> > Driver version : 5.5.0
> > Capabilities : 0x84208000
> > Video Memory-to-Memory
> > Streaming
> > Extended Pix Format
> > Device Capabilities
> > Device Caps : 0x04208000
> > Video Memory-to-Memory
> > Streaming
> > Extended Pix Format
> >
> > Required ioctls:
> > test VIDIOC_QUERYCAP: OK
> >
> > Allow for multiple opens:
> > test second /dev/video0 open: OK
> > test VIDIOC_QUERYCAP: OK
> > test VIDIOC_G/S_PRIORITY: OK
> > test for unlimited opens: OK
> >
> > test invalid ioctls: OK
> > Debug ioctls:
> > test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported)
> > test VIDIOC_LOG_STATUS: OK
> >
> > Input ioctls:
> > test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported)
> > test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
> > test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported)
> > test VIDIOC_ENUMAUDIO: OK (Not Supported)
> > test VIDIOC_G/S/ENUMINPUT: OK (Not Supported)
> > test VIDIOC_G/S_AUDIO: OK (Not Supported)
> > Inputs: 0 Audio Inputs: 0 Tuners: 0
> >
> > Output ioctls:
> > test VIDIOC_G/S_MODULATOR: OK (Not Supported)
> > test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
> > test VIDIOC_ENUMAUDOUT: OK (Not Supported)
> > test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported)
> > test VIDIOC_G/S_AUDOUT: OK (Not Supported)
> > Outputs: 0 Audio Outputs: 0 Modulators: 0
> >
> > Input/Output configuration ioctls:
> > test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported)
> > test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported)
> > test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported)
> > test VIDIOC_G/S_EDID: OK (Not Supported)
> >
> > Control ioctls:
> > test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
> > test VIDIOC_QUERYCTRL: OK
> > test VIDIOC_G/S_CTRL: OK
> > test VIDIOC_G/S/TRY_EXT_CTRLS: OK
> > test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK
> > test VIDIOC_G/S_JPEGCOMP: OK (Not Supported)
> > Standard Controls: 4 Private Controls: 0
> >
> > Format ioctls:
> > test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK
> > test VIDIOC_G/S_PARM: OK (Not Supported)
> > test VIDIOC_G_FBUF: OK (Not Supported)
> > test VIDIOC_G_FMT: OK
> > test VIDIOC_TRY_FMT: OK
> > test VIDIOC_S_FMT: OK
> > test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
> > test Cropping: OK (Not Supported)
> > test Composing: OK (Not Supported)
> > test Scaling: OK (Not Supported)
> >
> > Codec ioctls:
> > test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported)
> > test VIDIOC_G_ENC_INDEX: OK (Not Supported)
> > test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)
> >
> > Buffer ioctls:
> > test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK
> > test VIDIOC_EXPBUF: OK
> > test Requests: OK (Not Supported)
> >
> > Total for sun8i-rotate device /dev/video0: 45, Succeeded: 45, Failed: 0,
> > Warnings: 0
> >
> > Best regards,
> > Jernej
> >
> > Jernej Skrabec (8):
> > clk: sunxi-ng: sun8i-de2: Swap A64 and H6 definitions
> > clk: sunxi-ng: sun8i-de2: Fix A83T clocks and reset
>
> Please disregard above two patches. It turns out that many more changes are
> required to fix mess with rotation clocks and reset. I sent separate patch
> series: http://lists.infradead.org/pipermail/linux-arm-kernel/2020-February/
> 710242.html
>
> Comments on the rest of the series are welcome, though.
>
> Best regards,
> Jernej
>
> > ARM: dts: sunxi: Fix DE2 clocks register range
> > arm64: dts: allwinner: a64: Fix display clock register range
> > media: dt-bindings: media: Add Allwinner A83T Rotate driver
> > media: sun8i: Add Allwinner A83T Rotate driver
> > ARM: dts: sun8i: a83t: Add device node for rotation core
> > arm64: dts: allwinner: a64: add node for rotation core
Merged the DTS patches for 5.7.
ChenYu
> > .../allwinner,sun8i-a83t-de2-rotate.yaml | 70 ++
> > MAINTAINERS | 8 +
> > arch/arm/boot/dts/sun8i-a83t.dtsi | 13 +-
> > arch/arm/boot/dts/sun8i-r40.dtsi | 2 +-
> > arch/arm/boot/dts/sun8i-v3s.dtsi | 2 +-
> > arch/arm/boot/dts/sunxi-h3-h5.dtsi | 2 +-
> > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 14 +-
> > drivers/clk/sunxi-ng/ccu-sun8i-de2.c | 49 +-
> > drivers/media/platform/Kconfig | 12 +
> > drivers/media/platform/sunxi/Makefile | 1 +
> > .../platform/sunxi/sun8i-rotate/Makefile | 2 +
> > .../sunxi/sun8i-rotate/sun8i-formats.c | 273 ++++++
> > .../sunxi/sun8i-rotate/sun8i-formats.h | 25 +
> > .../sunxi/sun8i-rotate/sun8i-rotate.c | 924 ++++++++++++++++++
> > .../sunxi/sun8i-rotate/sun8i-rotate.h | 135 +++
> > 15 files changed, 1512 insertions(+), 20 deletions(-)
> > create mode 100644
> > Documentation/devicetree/bindings/media/allwinner,sun8i-a83t-de2-rotate.yam
> > l create mode 100644 drivers/media/platform/sunxi/sun8i-rotate/Makefile
> > create mode 100644
> > drivers/media/platform/sunxi/sun8i-rotate/sun8i-formats.c create mode
> > 100644 drivers/media/platform/sunxi/sun8i-rotate/sun8i-formats.h create
> > mode 100644 drivers/media/platform/sunxi/sun8i-rotate/sun8i-rotate.c create
> > mode 100644 drivers/media/platform/sunxi/sun8i-rotate/sun8i-rotate.h
>
>
>
>
prev parent reply other threads:[~2020-03-12 5:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 23:20 [PATCH 0/8] media: sunxi: Add DE2 rotate driver Jernej Skrabec
2020-01-24 23:20 ` [PATCH 1/8] clk: sunxi-ng: sun8i-de2: Swap A64 and H6 definitions Jernej Skrabec
2020-01-25 3:05 ` [linux-sunxi] " Chen-Yu Tsai
2020-01-25 11:20 ` Jernej Škrabec
2020-01-25 11:24 ` Jernej Škrabec
2020-01-24 23:20 ` [PATCH 2/8] clk: sunxi-ng: sun8i-de2: Fix A83T clocks and reset Jernej Skrabec
2020-01-24 23:20 ` [PATCH 3/8] ARM: dts: sunxi: Fix DE2 clocks register range Jernej Skrabec
2020-01-24 23:20 ` [PATCH 4/8] arm64: dts: allwinner: a64: Fix display clock " Jernej Skrabec
2020-01-24 23:20 ` [PATCH 5/8] media: dt-bindings: media: Add Allwinner A83T Rotate driver Jernej Skrabec
2020-02-03 15:48 ` Rob Herring
2020-01-24 23:20 ` [PATCH 6/8] media: sun8i: " Jernej Skrabec
2020-01-24 23:20 ` [PATCH 7/8] ARM: dts: sun8i: a83t: Add device node for rotation core Jernej Skrabec
2020-01-24 23:20 ` [PATCH 8/8] arm64: dts: allwinner: a64: add " Jernej Skrabec
2020-02-11 19:12 ` [linux-sunxi] [PATCH 0/8] media: sunxi: Add DE2 rotate driver Jernej Škrabec
2020-03-12 5:31 ` Chen-Yu Tsai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGb2v647N4oSf=txbCfc05L6j8_U4bBtfa+XxYX6ZUMmrYbs0Q@mail.gmail.com' \
--to=wens@csie.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jernej.skrabec@gmail.com \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).