From: Tim Harvey <tharvey@gateworks.com>
To: Nicolas Dufresne <nicolas@ndufresne.ca>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
linux-media <linux-media@vger.kernel.org>,
Steve Longerbeam <slongerbeam@gmail.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Sascha Hauer <kernel@pengutronix.de>
Subject: Re: [PATCH v7] media: imx: add mem2mem device
Date: Fri, 15 Feb 2019 15:36:57 -0800 [thread overview]
Message-ID: <CAJ+vNU2185akWh72cwh8G_zYqAG0KtPwN8KvbKQJ=v6GJpcaSQ@mail.gmail.com> (raw)
In-Reply-To: <04f7cf49df32b39f88b14a84df4fa38b1c7d24f6.camel@ndufresne.ca>
On Fri, Feb 15, 2019 at 8:24 AM Nicolas Dufresne <nicolas@ndufresne.ca> wrote:
>
> Le vendredi 15 février 2019 à 12:10 +0100, Philipp Zabel a écrit :
> > > I'm also not sure how to specify hflip/vflip... I don't think
> > > extra-controls parses 'hflip', 'vflip' as ipu_csc_scaler_s_ctrl gets
> > > called with V4L2_CID_HFLIP/V4L2_CID_VFLIP but ctrl->val is always 0.
> >
> > You can use v4l2-ctl -L to list the CID names, they are horizontal_flip
> > and vertical_flip, respectively. Again, the input and output formats
> > must be different because GStreamer doesn't know about the flipping yet:
> >
> > gst-launch-1.0 videotestsrc ! video/x-raw,width=320,height=240 ! v4l2video10convert extra-controls=cid,horizontal_flip=1 ! video/x-raw,width=640,height=480 ! kmssink can-scale=false
> >
> > We'd have to add actual properties for rotate/flip to v4l2convert,
> > instead of using theextra-controls workaround, probable something
> > similar to the video-direction property of the software videoflip
> > element.
>
> Note that we have a disable-passthrough property in master, a trivial
> patch to backport if you need it.
>
> https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/commit/fe5236be8771ea82c850ebebe19cf1064d112bf0
Nicolas,
Yes, this works great on gstreamer-master:
gst-launch-1.0 videotestsrc ! v4l2convert
extra-controls=cid,vertical_flip=1 ! kmssink
^^^ fails to flip b/c gstreamer bypases the conversion as input and
output formats are the same
gst-launch-1.0 videotestsrc ! v4l2convert
extra-controls=cid,vertical_flip=1 disable-passthrough=1 ! kmssink
^^^ flips as expected
Tim
next prev parent reply other threads:[~2019-02-15 23:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 15:50 [PATCH v7] media: imx: add mem2mem device Philipp Zabel
2019-01-18 9:30 ` Hans Verkuil
2019-01-18 11:18 ` Philipp Zabel
2019-01-18 12:41 ` Hans Verkuil
2019-01-18 13:42 ` Philipp Zabel
2019-01-18 13:45 ` Hans Verkuil
2019-01-18 14:17 ` Philipp Zabel
2019-01-18 16:51 ` Philipp Zabel
2019-01-19 9:28 ` Hans Verkuil
2019-02-12 19:01 ` Tim Harvey
2019-02-13 17:22 ` Nicolas Dufresne
2019-02-15 11:10 ` Philipp Zabel
2019-02-15 16:24 ` Nicolas Dufresne
2019-02-15 23:36 ` Tim Harvey [this message]
2019-02-15 23:34 ` Tim Harvey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ+vNU2185akWh72cwh8G_zYqAG0KtPwN8KvbKQJ=v6GJpcaSQ@mail.gmail.com' \
--to=tharvey@gateworks.com \
--cc=hans.verkuil@cisco.com \
--cc=kernel@pengutronix.de \
--cc=linux-media@vger.kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=p.zabel@pengutronix.de \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).