From: Dariusz Marcinkiewicz <darekm@google.com>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH v4 7/9] drm: tegra: use cec_notifier_conn_(un)register
Date: Wed, 7 Aug 2019 11:05:37 +0200 [thread overview]
Message-ID: <CALFZZQHcD1Tc-yJdUOAvop1eM3hhBwN6nbtOqZm=QVjQPHwACA@mail.gmail.com> (raw)
In-Reply-To: <ee5f00e9-f865-28a9-2b4c-63bb8206d4cd@xs4all.nl>
Hi Hans.
On Tue, Jul 30, 2019 at 2:17 PM Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote:
>
> Hi Dariusz,
>
> One comment below:
>
> > int tegra_output_init(struct drm_device *drm, struct tegra_output *output)
> > {
> > + struct cec_connector_info conn_info;
> > int err;
> >
> > if (output->panel) {
> > @@ -212,6 +209,13 @@ int tegra_output_init(struct drm_device *drm, struct tegra_output *output)
> > if (gpio_is_valid(output->hpd_gpio))
> > enable_irq(output->hpd_irq);
> >
> > + cec_fill_conn_info_from_drm(&conn_info, &output->connector);
> > +
>
> This isn't right: tegra_output_init() is called for various output types, but the
> CEC adapter should only be created for an HDMI connector. So there should be
> a check on the connector type before registering a cec notifier.
>
I have just sent out v5 patch series. In there I've updated this patch
to limit the notifier creation only to HDMI connectors. From a cursory
look, though, it seems that so far that the notifier was created
regardless of connector type, so we are changing the existing behavior
here.
Best regards.
next prev parent reply other threads:[~2019-08-07 9:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 12:27 [PATCH v4 0/9] drm: cec: convert DRM drivers to the new notifier API Dariusz Marcinkiewicz
2019-07-16 12:27 ` [PATCH v4 1/9] drm_dp_cec: add connector info support Dariusz Marcinkiewicz
2019-07-16 12:27 ` [PATCH v4 2/9] drm/i915/intel_hdmi: use cec_notifier_conn_(un)register Dariusz Marcinkiewicz
2019-07-16 12:27 ` [PATCH v4 3/9] dw-hdmi-cec: use cec_notifier_cec_adap_(un)register Dariusz Marcinkiewicz
2019-07-16 12:27 ` [PATCH v4 4/9] tda9950: " Dariusz Marcinkiewicz
2019-07-16 12:27 ` [PATCH v4 5/9] drm: tda998x: use cec_notifier_conn_(un)register Dariusz Marcinkiewicz
2019-07-16 12:27 ` [PATCH v4 6/9] drm: sti: " Dariusz Marcinkiewicz
2019-07-16 12:27 ` [PATCH v4 7/9] drm: tegra: " Dariusz Marcinkiewicz
2019-07-30 12:17 ` Hans Verkuil
2019-08-07 9:05 ` Dariusz Marcinkiewicz [this message]
2019-07-16 12:27 ` [PATCH v4 8/9] drm: dw-hdmi: " Dariusz Marcinkiewicz
2019-07-30 12:19 ` Hans Verkuil
2019-07-16 12:27 ` [PATCH v4 9/9] drm: exynos: exynos_hdmi: " Dariusz Marcinkiewicz
2019-07-30 12:23 ` [PATCH v4 0/9] drm: cec: convert DRM drivers to the new notifier API Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALFZZQHcD1Tc-yJdUOAvop1eM3hhBwN6nbtOqZm=QVjQPHwACA@mail.gmail.com' \
--to=darekm@google.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).