From: Rob Herring <robh@kernel.org>
To: Frederic Chen <frederic.chen@mediatek.com>
Cc: Hans Verkuil <hans.verkuil@cisco.com>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Tomasz Figa <tfiga@chromium.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
yuzhao@chromium.org, zwisler@chromium.org,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
Sean.Cheng@mediatek.com, sj.huang@mediatek.com,
christie.yu@mediatek.com, holmes.chiou@mediatek.com,
Jerry-ch Chen <Jerry-ch.Chen@mediatek.com>,
jungo.lin@mediatek.com, Rynn.Wu@mediatek.com,
Linux Media Mailing List <linux-media@vger.kernel.org>,
srv_heupstream <srv_heupstream@mediatek.com>,
devicetree@vger.kernel.org, shik@chromium.org,
suleiman@chromium.org
Subject: Re: [RFC PATCH V1 3/6] dt-bindings: mt8183: Added DIP dt-bindings
Date: Tue, 14 May 2019 11:14:19 -0500 [thread overview]
Message-ID: <CAL_JsqJ7+qrBEi4fXx1qC-3g17UGDJQ-LmahU9YUHaqr7QZQtQ@mail.gmail.com> (raw)
In-Reply-To: <1557238579.11663.15.camel@mtksdccf07>
On Tue, May 7, 2019 at 9:16 AM Frederic Chen <frederic.chen@mediatek.com> wrote:
>
> Dear Rob,
>
> I appreciate your comments.
>
> On Mon, 2019-04-29 at 20:16 -0500, Rob Herring wrote:
> > On Wed, Apr 17, 2019 at 06:45:08PM +0800, Frederic Chen wrote:
> > > This patch adds DT binding documentation for the Digital Image
> > > Processing (DIP) unit of camera ISP system on Mediatek's SoCs.
> > >
> > > Signed-off-by: Frederic Chen <frederic.chen@mediatek.com>
> > > ---
> > > .../bindings/media/mediatek,mt8183-dip.txt | 35 +++++++++++++++++++
> > > 1 file changed, 35 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/media/mediatek,mt8183-dip.txt
> > >
> > > diff --git a/Documentation/devicetree/bindings/media/mediatek,mt8183-dip.txt b/Documentation/devicetree/bindings/media/mediatek,mt8183-dip.txt
> > > new file mode 100644
> > > index 000000000000..0e1994bf82f0
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/media/mediatek,mt8183-dip.txt
> > > @@ -0,0 +1,35 @@
> > > +* Mediatek Digital Image Processor (DIP)
> > > +
> > > +Digital Image Processor (DIP) unit in Mediatek ISP system is responsible for
> > > +image content adjustment according to the tuning parameters. DIP can process
> > > +the image form memory buffer and output the processed image to multiple output
> > > +buffers. Furthermore, it can support demosaicing and noise reduction on the
> > > +images.
> > > +
> > > +Required properties:
> > > +- compatible: "mediatek,mt8183-dip"
> > > +- reg: Physical base address and length of the function block register space
> > > +- interrupts: interrupt number to the cpu
> > > +- iommus: should point to the respective IOMMU block with master port as
> > > + argument, see Documentation/devicetree/bindings/iommu/mediatek,iommu.txt
> > > + for details.
> > > +- mediatek,larb: must contain the local arbiters in the current Socs, see
> > > + Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.txt
> > > + for details.
> > > +- clocks: must contain the local arbiters 5 (LARB5) and DIP clock
> > > +- clock-names: must contain DIP_CG_IMG_LARB5 and DIP_CG_IMG_DIP
> > > +
> > > +Example:
> > > + dip: dip@15022000 {
> > > + compatible = "mediatek,mt8183-dip";
> > > + mediatek,larb = <&larb5>;
> >
> > > + mediatek,mdp3 = <&mdp_rdma0>;
> > > + mediatek,vpu = <&vpu>;
> >
> > Not documented.
> >
>
> “mediatek,vpu” will be replaced by “mediatek,scp.” I would like to
> add the following description in next version of the patch:
>
> - mediatek,scp: must point to the scp block of the co-processor used
> with DIP. Please see
> Documentation/devicetree/bindings/remoteproc/mtk,scp.txt for the
> detail.
>
> - mediatek,mdp3: must point to the Media Data Path 3 (MDP3) block.
> Please see
> Documentation/devicetree/bindings/media/mediatek,mt8183-mdp3.txt
> for the detail.
If there's only 1 of each of these blocks, there's no need to have
phandle. Just find the matching node using the compatible string(s).
Rob
next prev parent reply other threads:[~2019-05-14 16:14 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 10:45 [RFC PATCH V1 0/6] media: platform: Add support for Digital Image Processing (DIP) on mt8183 SoC Frederic Chen
2019-04-17 10:45 ` [RFC PATCH V1 1/6] dt-bindings: mt8183: Add binding for DIP shared memory Frederic Chen
2019-04-30 1:15 ` Rob Herring
2019-05-07 14:22 ` Frederic Chen
2019-05-14 16:19 ` Rob Herring
2019-05-16 6:12 ` Tomasz Figa
2019-05-17 22:22 ` Rob Herring
2019-04-17 10:45 ` [RFC PATCH V1 2/6] dts: arm64: mt8183: Add DIP shared memory node Frederic Chen
2019-04-17 10:45 ` [RFC PATCH V1 3/6] dt-bindings: mt8183: Added DIP dt-bindings Frederic Chen
2019-04-30 1:16 ` Rob Herring
2019-05-07 14:16 ` Frederic Chen
2019-05-14 16:14 ` Rob Herring [this message]
2019-04-17 10:45 ` [RFC PATCH V1 4/6] dts: arm64: mt8183: Add DIP nodes Frederic Chen
2019-04-17 10:45 ` [RFC PATCH V1 5/6] media: platform: Add Mediatek DIP driver KConfig Frederic Chen
2019-04-17 10:45 ` [RFC PATCH V1 6/6] platform: mtk-isp: Add Mediatek DIP driver Frederic Chen
2019-05-09 9:48 ` Tomasz Figa
2019-05-21 19:14 ` Frederic Chen
2019-05-22 10:25 ` Tomasz Figa
2019-05-23 13:46 ` Frederic Chen
2019-05-29 3:38 ` Tomasz Figa
2019-06-11 8:48 ` Frederic Chen
2019-06-11 8:59 ` Tomasz Figa
2019-06-11 10:07 ` Frederic Chen
2019-06-11 10:13 ` Tomasz Figa
2019-06-25 11:35 ` Frederic Chen
2019-06-25 12:16 ` Frederic Chen
2019-06-26 4:24 ` Tomasz Figa
2019-05-22 9:51 ` Shik Chen
2019-05-23 14:24 ` Frederic Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqJ7+qrBEi4fXx1qC-3g17UGDJQ-LmahU9YUHaqr7QZQtQ@mail.gmail.com \
--to=robh@kernel.org \
--cc=Jerry-ch.Chen@mediatek.com \
--cc=Rynn.Wu@mediatek.com \
--cc=Sean.Cheng@mediatek.com \
--cc=christie.yu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=frederic.chen@mediatek.com \
--cc=hans.verkuil@cisco.com \
--cc=holmes.chiou@mediatek.com \
--cc=jungo.lin@mediatek.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=shik@chromium.org \
--cc=sj.huang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=suleiman@chromium.org \
--cc=tfiga@chromium.org \
--cc=yuzhao@chromium.org \
--cc=zwisler@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).