From: "Rui Miguel Silva" <rmfrfs@gmail.com>
To: "Philipp Zabel" <p.zabel@pengutronix.de>,
"Dorota Czaplejewicz" <dorota.czaplejewicz@puri.sm>,
"Steve Longerbeam" <slongerbeam@gmail.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
<linux-media@vger.kernel.org>, <linux-staging@lists.linux.dev>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <kernel@puri.sm>,
<phone-devel@vger.kernel.org>
Cc: "Laurent Pinchart" <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCHv3 4/4] media: imx: Use dedicated format handler for i.MX7/8
Date: Thu, 04 Nov 2021 09:54:28 +0000 [thread overview]
Message-ID: <CFGWKJVG6WGV.3HK06KA8BFY11@arch-thunder> (raw)
In-Reply-To: <092d8c2ba808a25efab579a6d7cc32846c482206.camel@pengutronix.de>
Hi Philipp,
On Wed Nov 3, 2021 at 12:32 PM WET, Philipp Zabel wrote:
> On Tue, 2021-10-19 at 14:14 +0200, Dorota Czaplejewicz wrote:
> > This splits out a format handler which takes into account
> > the capabilities of the i.MX7/8 video device,
> > as opposed to the default handler compatible with both i.MX5/6 and i.MX7/8.
> >
> > Signed-off-by: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>
>
> Cc: Rui & Laurent
>
> Looks sane to me, but I'd like someone with i.MX7/8 media experience to
> have a look at this.
Thanks for the CC, this really went off of my radar. I will try to
take a look at it, but one of the comments on the first patch:
"The use of `v4l2_fill_pixfmt` comes with the downside of breaking
10-bit Bayer formats, or at least until my other series gets accepted
(Subject: "media: Add 16-bit Bayer formats". Sorry, I don't have the
message id.)."
made me wonder if that series was already accepted? without it this
will break the warp7 setup.
------
Cheers,
Rui
>
> Thread at
> https://lore.kernel.org/linux-media/20211019120047.827915-1-dorota.czaplejewicz@puri.sm/
>
> regards
> Philipp
next prev parent reply other threads:[~2021-11-04 9:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 12:13 [PATCHv3 1/4] media: imx: Remove unused functions Dorota Czaplejewicz
2021-10-19 12:13 ` [PATCHv3 2/4] media: imx: Store the type of hardware implementation Dorota Czaplejewicz
2021-10-19 12:14 ` [PATCHv3 3/4] media: imx: Forward " Dorota Czaplejewicz
2021-10-19 12:14 ` [PATCHv3 4/4] media: imx: Use dedicated format handler for i.MX7/8 Dorota Czaplejewicz
2021-11-03 12:32 ` Philipp Zabel
2021-11-04 9:54 ` Rui Miguel Silva [this message]
2022-01-28 10:57 ` Hans Verkuil
2021-11-03 12:32 ` [PATCHv3 1/4] media: imx: Remove unused functions Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CFGWKJVG6WGV.3HK06KA8BFY11@arch-thunder \
--to=rmfrfs@gmail.com \
--cc=dorota.czaplejewicz@puri.sm \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=kernel@puri.sm \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=phone-devel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).