RE: [PATCH v5 2/5] media: dt-bindings: media: renesas,drif: Convert to json-schema

[Fabrizio Castro <fabrizio.castro.jz@renesas.com>]

Hi Geert,

Thank you for your feedback.

> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: 14 January 2021 13:03
> Subject: Re: [PATCH v5 2/5] media: dt-bindings: media: renesas,drif:
> Convert to json-schema
> 
> Hi Fabrizio, Rob,
> 
> On Wed, Oct 21, 2020 at 3:53 PM Fabrizio Castro
> <fabrizio.castro.jz@renesas.com> wrote:
> > Convert the Renesas DRIF bindings to DT schema and update
> > MAINTAINERS accordingly.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> 
> Thanks for your patch!
> 
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml
> 
> > +  clock-names:
> > +    maxItems: 1
> > +    items:
> > +      - const: fck
> 
> With latest dt-schema, "make dt_binding_check" complains:
> 
>     Documentation/devicetree/bindings/media/renesas,drif.yaml:
> properties:clock-names:maxItems: False schema does not allow 1
>     Documentation/devicetree/bindings/media/renesas,drif.yaml:
> ignoring, error in schema: properties: clock-names: maxItems
> 
> Using
> 
>        clock-names:
>          const: fck
> 
> Fixes that.

Do you need me to send a new version or are you going to amend
this on your end?

> 
> However, I'm wondering why I do not get a complaint about the similar
> clock/clock-names in
> Documentation/devicetree/bindings/display/bridge/renesas,lvds.yaml.
> Because they're part of an else branch?

Interesting, renesas,lvds.yaml doesn't seem to trigger the problem
from within the "then" branch either if I hack it, it only seems to
trigger the problem when outside the if statement.

We probably need to remove "maxItems: 1" from renesas,lvds.yaml as
well though, what do you think?

Thanks,
Fab

> 
> Thanks!
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker.
> But
> when I'm talking to journalists I just say "programmer" or something like
> that.
>                                 -- Linus Torvalds