From: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
LUU HOAI <hoai.luu.ub@renesas.com>
Subject: Re: [PATCH v2] media: rcar-csi2: Enable support for r8a77961
Date: Mon, 17 May 2021 13:44:39 +0200 [thread overview]
Message-ID: <YKJXJ0ZnEXFuuecz@oden.dyn.berto.se> (raw)
In-Reply-To: <CAMuHMdXnduG8q4tmXTgOEgHdyqqVQgXs7s93rif_4yQ-foJGWw@mail.gmail.com>
Hi Geert,
On 2021-05-17 11:51:48 +0200, Geert Uytterhoeven wrote:
> Hi Niklas,
>
> On Thu, May 13, 2021 at 4:10 PM Niklas Söderlund
> <niklas.soderlund+renesas@ragnatech.se> wrote:
> > Enable support for M3-W+ (r8a77961).
> >
> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> > Tested-by: LUU HOAI <hoai.luu.ub@renesas.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> > ---
> > * Changes since v1
> > - Do not piggy back on the M3-W (r8a7796) quirks as they are different.
>
> But for now they're still handled the same way...
>
> > --- a/drivers/media/platform/rcar-vin/rcar-csi2.c
> > +++ b/drivers/media/platform/rcar-vin/rcar-csi2.c
> > @@ -1112,6 +1112,11 @@ static const struct rcar_csi2_info rcar_csi2_info_r8a7796 = {
> > .num_channels = 4,
> > };
> >
> > +static const struct rcar_csi2_info rcar_csi2_info_r8a77961 = {
> > + .hsfreqrange = hsfreqrange_m3w_h3es1,
> > + .num_channels = 4,
> > +};
>
> ... as rcar_csi2_info_r8a77961 has the same contents as rcar_csi2_info_r8a7796?
Yes the structures are currently the same but the one added here is
correct while rcar_csi2_info_r8a7796 will need a new qurik field added
in a different patch.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
--
Regards,
Niklas Söderlund
prev parent reply other threads:[~2021-05-17 11:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 14:09 [PATCH v2] media: rcar-csi2: Enable support for r8a77961 Niklas Söderlund
2021-05-17 9:51 ` Geert Uytterhoeven
2021-05-17 11:44 ` Niklas Söderlund [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKJXJ0ZnEXFuuecz@oden.dyn.berto.se \
--to=niklas.soderlund+renesas@ragnatech.se \
--cc=geert@linux-m68k.org \
--cc=hoai.luu.ub@renesas.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).