From: Hans Verkuil <hverkuil@xs4all.nl>
To: Linux Media Mailing List <linux-media@vger.kernel.org>
Cc: Sowjanya Komatineni <skomatineni@nvidia.com>
Subject: [PATCH] imx219: selection compliance fixes
Date: Thu, 2 Jul 2020 15:50:04 +0200 [thread overview]
Message-ID: <b580ac9d-5ae4-29ce-c81a-a1f98b1d953b@xs4all.nl> (raw)
The top/left crop coordinates were 0, 0 instead of 8, 8 in the
supported_modes array. This was a mismatch with the default values,
so this is corrected. Found with v4l2-compliance.
Also add V4L2_SEL_TGT_CROP_BOUNDS support: CROP_DEFAULT and CROP_BOUNDS
always go together. Found with v4l2-compliance.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
---
drivers/media/i2c/imx219.c | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
index 0a546b8e466c..935e2a258ce5 100644
--- a/drivers/media/i2c/imx219.c
+++ b/drivers/media/i2c/imx219.c
@@ -473,8 +473,8 @@ static const struct imx219_mode supported_modes[] = {
.width = 3280,
.height = 2464,
.crop = {
- .left = 0,
- .top = 0,
+ .left = 8,
+ .top = 8,
.width = 3280,
.height = 2464
},
@@ -489,8 +489,8 @@ static const struct imx219_mode supported_modes[] = {
.width = 1920,
.height = 1080,
.crop = {
- .left = 680,
- .top = 692,
+ .left = 8 + 680,
+ .top = 8 + 692,
.width = 1920,
.height = 1080
},
@@ -505,8 +505,8 @@ static const struct imx219_mode supported_modes[] = {
.width = 1640,
.height = 1232,
.crop = {
- .left = 0,
- .top = 0,
+ .left = 8,
+ .top = 8,
.width = 3280,
.height = 2464
},
@@ -521,8 +521,8 @@ static const struct imx219_mode supported_modes[] = {
.width = 640,
.height = 480,
.crop = {
- .left = 1000,
- .top = 752,
+ .left = 8 + 1000,
+ .top = 8 + 752,
.width = 1280,
.height = 960
},
@@ -1014,6 +1014,7 @@ static int imx219_get_selection(struct v4l2_subdev *sd,
return 0;
case V4L2_SEL_TGT_CROP_DEFAULT:
+ case V4L2_SEL_TGT_CROP_BOUNDS:
sel->r.top = IMX219_PIXEL_ARRAY_TOP;
sel->r.left = IMX219_PIXEL_ARRAY_LEFT;
sel->r.width = IMX219_PIXEL_ARRAY_WIDTH;
--
2.27.0
next reply other threads:[~2020-07-02 13:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 13:50 Hans Verkuil [this message]
2020-07-14 12:31 ` [PATCH] imx219: selection compliance fixes Jacopo Mondi
2020-07-14 23:49 ` Laurent Pinchart
2020-07-15 7:19 ` Jacopo Mondi
2020-07-16 9:48 ` Hans Verkuil
2020-07-16 12:59 ` Laurent Pinchart
2020-07-16 13:53 ` Hans Verkuil
2020-07-16 23:20 ` Laurent Pinchart
2020-07-17 6:34 ` Jacopo Mondi
2020-08-01 11:19 ` Jacopo Mondi
2020-08-01 15:13 ` Laurent Pinchart
2020-08-03 8:33 ` Jacopo Mondi
2020-08-03 9:07 ` Hans Verkuil
2020-08-03 8:37 ` Hans Verkuil
2020-08-03 9:58 ` [libcamera-devel] " Dave Stevenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b580ac9d-5ae4-29ce-c81a-a1f98b1d953b@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=skomatineni@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).