From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Joe Perches <joe@perches.com>,
mchehab@kernel.org, akpm@linux-foundation.org, rppt@kernel.org,
hverkuil-cisco@xs4all.nl
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] media: bt8xx: avoid a useless memset
Date: Tue, 28 Jul 2020 10:01:20 +0200 [thread overview]
Message-ID: <b883b856-af1e-a017-6af2-2aca575c24d5@wanadoo.fr> (raw)
In-Reply-To: <0897d9bec8865859694c917f3f72ab8fd12321ff.camel@perches.com>
Le 27/07/2020 à 18:09, Joe Perches a écrit :
> On Mon, 2020-07-27 at 15:51 +0200, Christophe JAILLET wrote:
>> Avoid a memset after a call to 'dma_alloc_coherent()'.
>> This is useless since
>> commit 518a2f1925c3 ("dma-mapping: zero memory returned from dma_alloc_*")
> []
>> diff --git a/drivers/media/pci/bt8xx/btcx-risc.c b/drivers/media/pci/bt8xx/btcx-risc.c
> []
>> @@ -73,7 +73,6 @@ int btcx_riscmem_alloc(struct pci_dev *pci,
>> dprintk("btcx: riscmem alloc [%d] dma=%lx cpu=%p size=%d\n",
>> memcnt, (unsigned long)dma, cpu, size);
>> }
>> - memset(risc->cpu,0,risc->size);
>> return 0;
>> }
>
> Likely NAK.
>
> This is not useless as risc->cpu may be reused
> and the alloc may not have been done.
>
>
>
Agreed.
This 2/2 patch should be NAK'ed.
I've been a bit too fast on this one.
Thanks for the review Joe.
CJ
prev parent reply other threads:[~2020-07-28 8:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 13:51 [PATCH 2/2] media: bt8xx: avoid a useless memset Christophe JAILLET
2020-07-27 16:09 ` Joe Perches
2020-07-27 16:16 ` Joe Perches
2020-07-28 8:05 ` Christophe JAILLET
2020-07-28 9:25 ` Joe Perches
2020-07-28 8:01 ` Christophe JAILLET [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b883b856-af1e-a017-6af2-2aca575c24d5@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=akpm@linux-foundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).