linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kieran Bingham <kieran.bingham@ideasonboard.com>
To: Andreas Pape <ap@ca-pape.de>, linux-media@vger.kernel.org
Subject: Re: [PATCH 1/3] media: stkwebcam: Support for ASUS A6VM notebook added.
Date: Mon, 26 Nov 2018 12:48:53 +0000	[thread overview]
Message-ID: <ca22a6ae-f17a-8158-99af-376657adf730@ideasonboard.com> (raw)
In-Reply-To: <20181123161454.3215-2-ap@ca-pape.de>

Hi Andreas,

Thank you for the patch,

On 23/11/2018 16:14, Andreas Pape wrote:
> The ASUS A6VM notebook has a built in stk11xx webcam which is mounted
> in a way that the video is vertically and horizontally flipped.
> Therefore this notebook is added to the special handling in the driver
> to automatically flip the video into the correct orientation.
> 
> Signed-off-by: Andreas Pape <ap@ca-pape.de>
> ---
>  drivers/media/usb/stkwebcam/stk-webcam.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/media/usb/stkwebcam/stk-webcam.c b/drivers/media/usb/stkwebcam/stk-webcam.c
> index e11d5d5b7c26..e61427e50525 100644
> --- a/drivers/media/usb/stkwebcam/stk-webcam.c
> +++ b/drivers/media/usb/stkwebcam/stk-webcam.c
> @@ -116,6 +116,13 @@ static const struct dmi_system_id stk_upside_down_dmi_table[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "T12Rg-H")
>  		}
>  	},
> +	{
> +		.ident = "ASUS A6VM",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK Computer Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "A6VM")
> +		}

I guess these strings match the strings produced by dmi-decode on your
laptop?

Assuming so:

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>


> +	},
>  	{}
>  };
>  
> 

-- 
Regards
--
Kieran

  reply	other threads:[~2018-11-26 23:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-23 16:14 [PATCH 0/3] Fix for webcam issues with ASUS A6VM Andreas Pape
2018-11-23 16:14 ` [PATCH 1/3] media: stkwebcam: Support for ASUS A6VM notebook added Andreas Pape
2018-11-26 12:48   ` Kieran Bingham [this message]
2018-11-30 15:07     ` Andreas Pape
2018-11-23 16:14 ` [PATCH 2/3] media: stkwebcam: Bugfix for not correctly initialized camera Andreas Pape
2018-11-26 12:48   ` Kieran Bingham
2018-11-30 14:58     ` Andreas Pape
2018-12-05 18:56       ` Mauro Carvalho Chehab
2018-12-05 19:08         ` Mauro Carvalho Chehab
2018-11-23 16:14 ` [PATCH 3/3] media: stkwebcam: Bugfix for wrong return values Andreas Pape
2018-11-26 12:33   ` Kieran Bingham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca22a6ae-f17a-8158-99af-376657adf730@ideasonboard.com \
    --to=kieran.bingham@ideasonboard.com \
    --cc=ap@ca-pape.de \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).