From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
To: Linux Media Mailing List <linux-media@vger.kernel.org>
Cc: Dafna Hirschfeld <dafna3@gmail.com>,
Helen Koike <helen.koike@collabora.com>
Subject: [GIT PULL FOR v5.2] vicodec: support the stateless decoder
Date: Wed, 20 Mar 2019 15:41:59 +0100 [thread overview]
Message-ID: <d8b53a00-b786-22e8-1e4d-3a88c75225e8@xs4all.nl> (raw)
Hi Mauro,
This series adds support for a stateless decoder to vicodec.
Patches 1-3 add support for the vb2 requires_requests flag and return EBADR
instead of EACCES when requests are used when they shouldn't or vice versa.
Patches 4-17 fix bugs and prepare vicodec for adding the stateless decoder.
Patches 18-20 document the new stateless FWHT pixelformat and the vicodec
controls. Patch 21-22 adds the core support for these new controls/pixelformat.
And finally, patches 23-25 add the actual stateless decoder.
Note that since the stateless codec spec isn't finalized yet, the fwht state
control is defined in media/fwht-ctrls.h instead of v4l2-controls.h. Once the
stateless codec spec is accepted, and once a stateless encoder has been added
as well, then this can be moved to v4l2-controls.h.
This work was done by Dafna Hirschfeld as the second part of her Outreachy project.
The first part was fixing the vicodec stateful codec so it was in line with the
proposed stateful codec specification, and that code has been merged already.
I would like to thank Dafna for her work on this, it is very much appreciated!
Regards,
Hans
Changes since the previous pull request:
https://www.mail-archive.com/linux-media@vger.kernel.org/msg145727.html
- Rebased (this dropped the first two patches of the previous pull request since
those were merged)
- Patches 3-5 of the previous pull request are replaced by:
https://patchwork.linuxtv.org/patch/55159/
https://patchwork.linuxtv.org/patch/55160/
https://patchwork.linuxtv.org/patch/55162/
- All other patches are unchanged.
The following changes since commit 8a3946cad244e8453e26f3ded5fe40bf2627bb30:
media: v4l2-fwnode: Add a deprecation note in the old ACPI parsing example (2019-03-20 06:37:55 -0400)
are available in the Git repository at:
git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.2e
for you to fetch changes up to a3e73dfbba99f0c7ebef9c4ffeb03a491df3b172:
media: vicodec: set pixelformat to V4L2_PIX_FMT_FWHT_STATELESS for stateless decoder (2019-03-20 15:32:33 +0100)
----------------------------------------------------------------
Tag branch
----------------------------------------------------------------
Dafna Hirschfeld (20):
media: vicodec: selection api should only check single buffer types
media: vicodec: upon release, call m2m release before freeing ctrl handler
media: v4l2-ctrl: v4l2_ctrl_request_setup returns with error upon failure
media: vicodec: change variable name for the return value of v4l2_fwht_encode
media: vicodec: bugfix - call v4l2_m2m_buf_copy_metadata also if decoding fails
media: vicodec: bugfix: free compressed_frame upon device release
media: vicodec: Move raw frame preparation code to a function
media: vicodec: add field 'buf' to fwht_raw_frame
media: vicodec: keep the ref frame according to the format in decoder
media: vicodec: Validate version dependent header values in a separate function
media: vicodec: rename v4l2_fwht_default_fmt to v4l2_fwht_find_nth_fmt
media: vicodec: Handle the case that the reference buffer is NULL
media: vicodec: add struct for encoder/decoder instance
media: vicodec: add documentation to V4L2_CID_FWHT_I/P_FRAME_QP
media: vicodec: add documentation to V4L2_CID_MPEG_VIDEO_FWHT_PARAMS
media: vicodec: add documentation to V4L2_PIX_FMT_FWHT_STATELESS
media: vicodec: Introducing stateless fwht defs and structs
media: vicodec: Register another node for stateless decoder
media: vicodec: Add support for stateless decoder.
media: vicodec: set pixelformat to V4L2_PIX_FMT_FWHT_STATELESS for stateless decoder
Hans Verkuil (5):
vb2: add requires_requests bit for stateless codecs
cedrus: set requires_requests
media requests: return EBADR instead of EACCES
vicodec: fix g_selection: either handle crop or compose
v4l2-ioctl.c: add V4L2_PIX_FMT_FWHT_STATELESS to v4l_fill_fmtdesc
Documentation/media/uapi/mediactl/request-api.rst | 2 +-
Documentation/media/uapi/v4l/buffer.rst | 2 +-
Documentation/media/uapi/v4l/ext-ctrls-codec.rst | 130 +++++++++
Documentation/media/uapi/v4l/pixfmt-compressed.rst | 6 +
Documentation/media/uapi/v4l/vidioc-qbuf.rst | 10 +-
drivers/media/common/videobuf2/videobuf2-core.c | 9 +
drivers/media/common/videobuf2/videobuf2-v4l2.c | 6 +-
drivers/media/media-request.c | 4 +-
drivers/media/platform/vicodec/codec-fwht.c | 92 ++++---
drivers/media/platform/vicodec/codec-fwht.h | 12 +-
drivers/media/platform/vicodec/codec-v4l2-fwht.c | 431 +++++++++---------------------
drivers/media/platform/vicodec/codec-v4l2-fwht.h | 7 +-
drivers/media/platform/vicodec/vicodec-core.c | 750 +++++++++++++++++++++++++++++++++++++---------------
drivers/media/v4l2-core/v4l2-ctrls.c | 30 ++-
drivers/media/v4l2-core/v4l2-ioctl.c | 1 +
drivers/staging/media/sunxi/cedrus/cedrus_video.c | 1 +
include/media/fwht-ctrls.h | 31 +++
include/media/media-request.h | 4 +-
include/media/v4l2-ctrls.h | 7 +-
include/media/videobuf2-core.h | 3 +
include/uapi/linux/v4l2-controls.h | 4 +
include/uapi/linux/videodev2.h | 1 +
22 files changed, 968 insertions(+), 575 deletions(-)
create mode 100644 include/media/fwht-ctrls.h
next reply other threads:[~2019-03-20 14:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 14:41 Hans Verkuil [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-03-14 8:04 [GIT PULL FOR v5.2] vicodec: support the stateless decoder Hans Verkuil
2019-03-20 10:24 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8b53a00-b786-22e8-1e4d-3a88c75225e8@xs4all.nl \
--to=hverkuil-cisco@xs4all.nl \
--cc=dafna3@gmail.com \
--cc=helen.koike@collabora.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).