From: Jiri Kosina <jikos@kernel.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH 1/7] Input: document meanings of KEY_SCREEN and KEY_ZOOM
Date: Mon, 21 Jan 2019 11:11:19 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.1901211110190.6626@cbobk.fhfr.pm> (raw)
In-Reply-To: <20190118233037.87318-1-dmitry.torokhov@gmail.com>
On Fri, 18 Jan 2019, Dmitry Torokhov wrote:
> It is hard to say what KEY_SCREEN and KEY_ZOOM mean, but historically DVB
> folks have used them to indicate switch to full screen mode. Later, they
> converged on using KEY_ZOOM to switch into full screen mode and KEY)SCREEN
> to control aspect ratio (see Documentation/media/uapi/rc/rc-tables.rst).
>
> Let's commit to these uses, and define:
>
> - KEY_FULL_SCREEN (and make KEY_ZOOM its alias)
> - KEY_ASPECT_RATIO (and make KEY_SCREEN its alias)
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>
> Please let me know how we want merge this. Some of patches can be applied
> independently and I tried marking them as such, but some require new key
> names from input.h
Acked-by: Jiri Kosina <jkosina@suse.cz>
for the HID changes, and feel free to take it through your tree as a
whole, I don't expect any major conflicts rising up from this.
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2019-01-21 10:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 23:30 [PATCH 1/7] Input: document meanings of KEY_SCREEN and KEY_ZOOM Dmitry Torokhov
2019-01-18 23:30 ` [PATCH 2/7] [media] doc-rst: switch to new names for Full Screen/Aspect keys Dmitry Torokhov
2019-02-18 7:26 ` Dmitry Torokhov
2019-03-21 12:20 ` Mauro Carvalho Chehab
2019-01-21 10:11 ` Jiri Kosina [this message]
2019-01-21 10:41 ` [PATCH 1/7] Input: document meanings of KEY_SCREEN and KEY_ZOOM Benjamin Tissoires
2019-01-23 22:07 ` Dmitry Torokhov
2019-03-21 12:17 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.1901211110190.6626@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).