From: Robert Schlabbach <Robert.Schlabbach@gmx.net>
To: Piotr Chmura <chmooreck@gmail.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH] si2157: unknown chip version Si2147-A30 ROM 0x50
Date: Wed, 23 Mar 2022 09:25:25 +0100 [thread overview]
Message-ID: <trinity-cde2127b-c65f-4185-af2c-605f2b6b1028-1648023925588@3c-app-gmx-bs25> (raw)
In-Reply-To: <6f84b7f4-3ede-ae55-e99b-a9d4108c80e2@gmail.com>
Hi Piotr,
wow, well spotted! I did not notice this bug with my Si2157, because the ROM file
still has the old "alt" name on my machine, so it was loaded despite this bug.
Best Regards,
-Robert Schlabbach
Gesendet: Mittwoch, 23. März 2022 um 00:08 Uhr
Von: "Piotr Chmura" <chmooreck@gmail.com>
An: linux-media@vger.kernel.org
Betreff: [PATCH] si2157: unknown chip version Si2147-A30 ROM 0x50
This patch fixes firmware file names assignment in si2157 tuner.
kernel version: 5.17.0
device: 07ca:1871 AVerMedia Technologies, Inc. TD310 DVB-T/T2/C dongle
modprobe gives error: unknown chip version Si2147-A30 ROM 0x50
device worked fine on 2.16 series
caused by:
1. table si2157_tuners has swapped fields rom_id and required vs struct
si2157_tuner_info.
2. both firmware file names can be null for devices with required ==
false - device uses build-in firmware in this case
Tested on my device.
Signed-of-by: Piotr Chmura <chmooreck@poczta.onet.pl>
---
diff -u a/drivers/media/tuners/si2157.c b/drivers/media/tuners/si2157.c
--- a/drivers/media/tuners/si2157.c 2022-03-20 21:14:17.000000000 +0100
+++ b/drivers/media/tuners/si2157.c 2022-03-22 23:48:05.604408331 +0100
@@ -77,16 +77,16 @@
}
static const struct si2157_tuner_info si2157_tuners[] = {
- { SI2141, false, 0x60, SI2141_60_FIRMWARE, SI2141_A10_FIRMWARE },
- { SI2141, false, 0x61, SI2141_61_FIRMWARE, SI2141_A10_FIRMWARE },
- { SI2146, false, 0x11, SI2146_11_FIRMWARE, NULL },
- { SI2147, false, 0x50, SI2147_50_FIRMWARE, NULL },
- { SI2148, true, 0x32, SI2148_32_FIRMWARE, SI2158_A20_FIRMWARE },
- { SI2148, true, 0x33, SI2148_33_FIRMWARE, SI2158_A20_FIRMWARE },
- { SI2157, false, 0x50, SI2157_50_FIRMWARE, SI2157_A30_FIRMWARE },
- { SI2158, false, 0x50, SI2158_50_FIRMWARE, SI2158_A20_FIRMWARE },
- { SI2158, false, 0x51, SI2158_51_FIRMWARE, SI2158_A20_FIRMWARE },
- { SI2177, false, 0x50, SI2177_50_FIRMWARE, SI2157_A30_FIRMWARE },
+ { SI2141, 0x60, false, SI2141_60_FIRMWARE, SI2141_A10_FIRMWARE },
+ { SI2141, 0x61, false, SI2141_61_FIRMWARE, SI2141_A10_FIRMWARE },
+ { SI2146, 0x11, false, SI2146_11_FIRMWARE, NULL },
+ { SI2147, 0x50, false, SI2147_50_FIRMWARE, NULL },
+ { SI2148, 0x32, true, SI2148_32_FIRMWARE, SI2158_A20_FIRMWARE },
+ { SI2148, 0x33, true, SI2148_33_FIRMWARE, SI2158_A20_FIRMWARE },
+ { SI2157, 0x50, false, SI2157_50_FIRMWARE, SI2157_A30_FIRMWARE },
+ { SI2158, 0x50, false, SI2158_50_FIRMWARE, SI2158_A20_FIRMWARE },
+ { SI2158, 0x51, false, SI2158_51_FIRMWARE, SI2158_A20_FIRMWARE },
+ { SI2177, 0x50, false, SI2177_50_FIRMWARE, SI2157_A30_FIRMWARE },
};
static int si2157_load_firmware(struct dvb_frontend *fe,
@@ -178,7 +178,7 @@
}
}
- if (!fw_name && !fw_alt_name) {
+ if (required && !fw_name && !fw_alt_name) {
dev_err(&client->dev,
"unknown chip version Si21%d-%c%c%c ROM 0x%02x\n",
part_id, cmd.args[1], cmd.args[3], cmd.args[4], rom_id);
next prev parent reply other threads:[~2022-03-23 8:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 23:08 [PATCH] si2157: unknown chip version Si2147-A30 ROM 0x50 Piotr Chmura
2022-03-23 8:25 ` Robert Schlabbach [this message]
2022-03-23 17:50 ` Robert Schlabbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=trinity-cde2127b-c65f-4185-af2c-605f2b6b1028-1648023925588@3c-app-gmx-bs25 \
--to=robert.schlabbach@gmx.net \
--cc=chmooreck@gmail.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).