From: Florian Fainelli <f.fainelli@gmail.com>
To: David Miller <davem@davemloft.net>, rmk+kernel@armlinux.org.uk
Cc: andrew@lunn.ch, nbd@openwrt.org, radhey.shyam.pandey@xilinx.com,
alexandre.torgue@st.com, netdev@vger.kernel.org,
sean.wang@mediatek.com, linux-stm32@st-md-mailman.stormreply.com,
nicolas.ferre@microchip.com, vivien.didelot@gmail.com,
michal.simek@xilinx.com, joabreu@synopsys.com,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
thomas.petazzoni@bootlin.com, john@phrozen.org,
matthias.bgg@gmail.com, peppe.cavallaro@st.com,
Mark-MC.Lee@mediatek.com, mcoquelin.stm32@gmail.com,
hkallweit1@gmail.com
Subject: Re: [CFT PATCH net-next v2] net: phylink: rename mac_link_state() op to mac_pcs_get_state()
Date: Thu, 21 Nov 2019 19:36:44 -0800 [thread overview]
Message-ID: <0a9e016b-4ee3-1f1c-0222-74180f130e6c@gmail.com> (raw)
In-Reply-To: <20191121.191417.1339124115325210078.davem@davemloft.net>
On 11/21/2019 7:14 PM, David Miller wrote:
> From: Russell King <rmk+kernel@armlinux.org.uk>
> Date: Thu, 21 Nov 2019 00:36:22 +0000
>
>> Rename the mac_link_state() method to mac_pcs_get_state() to make it
>> clear that it should be returning the MACs PCS current state, which
>> is used for inband negotiation rather than just reading back what the
>> MAC has been configured for. Update the documentation to explicitly
>> mention that this is for inband.
>>
>> We drop the return value as well; most of phylink doesn't check the
>> return value and it is not clear what it should do on error - instead
>> arrange for state->link to be false.
>>
>> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
>> ---
>> This is something I'd like to do to make it clearer what phylink
>> expects of this function, and that it shouldn't just read-back how
>> the MAC was configured.
>>
>> This version drops the deeper changes, concentrating just on the
>> phylink API rather than delving deeper into drivers, as I haven't
>> received any feedback on that patch.
>>
>> It would be nice to see all these drivers tested with this change.
>
> I'm tempted to just apply this, any objections?
>
Russell, which of this patch or: http://patchwork.ozlabs.org/patch/1197425/
would you consider worthy of merging?
--
Florian
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2019-11-22 3:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 0:36 [CFT PATCH net-next v2] net: phylink: rename mac_link_state() op to mac_pcs_get_state() Russell King
2019-11-22 3:14 ` David Miller
2019-11-22 3:36 ` Florian Fainelli [this message]
2019-11-22 9:21 ` Russell King - ARM Linux admin
2019-11-23 18:38 ` Jakub Kicinski
2019-11-23 20:30 ` Florian Fainelli
2019-11-24 0:15 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a9e016b-4ee3-1f1c-0222-74180f130e6c@gmail.com \
--to=f.fainelli@gmail.com \
--cc=Mark-MC.Lee@mediatek.com \
--cc=alexandre.torgue@st.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=joabreu@synopsys.com \
--cc=john@phrozen.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=nbd@openwrt.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=peppe.cavallaro@st.com \
--cc=radhey.shyam.pandey@xilinx.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=sean.wang@mediatek.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).