From: moudy ho <moudy.ho@mediatek.com>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
<linux-media@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH v1 1/6] media: platform: mtk-mdp3: add chip configuration header file
Date: Tue, 11 Oct 2022 10:02:43 +0800 [thread overview]
Message-ID: <1da5fa8c9b22dcc8ada4e4e32a910dd552cc17d4.camel@mediatek.com> (raw)
In-Reply-To: <9e14ae09-6100-a55f-7aa7-6ed9edb49e09@collabora.com>
On Fri, 2022-10-07 at 11:07 +0200, AngeloGioacchino Del Regno wrote:
> Il 07/10/22 05:17, Moudy Ho ha scritto:
> > In order to be compatible with more MDP3 chip settings in the
> > future,
> > move the chip-related configuration to a separate header file.
> >
> > Signed-off-by: Moudy Ho <moudy.ho@mediatek.com>
> > ---
> > .../media/platform/mediatek/mdp3/mt8183_mdp.h | 35
> > +++++++++++++++++++
>
> What if we choose a better name format for the chip header?
> Would mdp3-plat-mt8183.h work for you?
>
> Aside from that, the changes look good... but anyway, what this
> driver
> really needs is an abstraction of `mtk-img-ipi.h` since, as you know,
> new
> SoCs are using a different firmware and even a different architecture
> for
> the MCU.
>
> Is that planned?
>
> I think that such change would perfectly fit inside of this series.
>
> Regards,
> Angelo
>
Hi Angelo,
Thanks for all your advice, I will add another patch for SCP shared
memory header separation by chip, and integrate the following series
with the same purpose here.
[1]
https://patchwork.kernel.org/project/linux-mediatek/list/?series=683671
Sincerely,
Moudy
> > .../platform/mediatek/mdp3/mtk-mdp3-core.c | 27 ++------------
> > 2 files changed, 37 insertions(+), 25 deletions(-)
> > create mode 100644
> > drivers/media/platform/mediatek/mdp3/mt8183_mdp.h
> >
>
>
next prev parent reply other threads:[~2022-10-11 2:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 3:17 [PATCH v1 0/6] Add support for multiple chips Moudy Ho
2022-10-07 3:17 ` [PATCH v1 1/6] media: platform: mtk-mdp3: add chip configuration header file Moudy Ho
2022-10-07 9:07 ` AngeloGioacchino Del Regno
2022-10-11 2:02 ` moudy ho [this message]
2022-10-07 3:17 ` [PATCH v1 2/6] media: platform: mtk-mdp3: chip config split about component settings Moudy Ho
2022-10-07 3:17 ` [PATCH v1 3/6] media: platform: mtk-mdp3: chip config split about subcomponents Moudy Ho
2022-10-07 3:17 ` [PATCH v1 4/6] media: platform: mtk-mdp3: chip config split about color format Moudy Ho
2022-10-07 3:17 ` [PATCH v1 5/6] media: platform: mtk-mdp3: chip config split about resolution limitations Moudy Ho
2022-10-07 3:17 ` [PATCH v1 6/6] media: platform: mtk-mdp3: chip config split about pipe info Moudy Ho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1da5fa8c9b22dcc8ada4e4e32a910dd552cc17d4.camel@mediatek.com \
--to=moudy.ho@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).