From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bin Liu <b-liu@ti.com>, Chunfeng Yun <chunfeng.yun@mediatek.com>,
Felipe Balbi <balbi@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Peter Chen <Peter.Chen@nxp.com>,
Minas Harutyunyan <hminas@synopsys.com>,
Cristian Birsan <cristian.birsan@microchip.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Kevin Cernekee <cernekee@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
bcm-kernel-feedback-list@broadcom.com,
Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Stephen Boyd <swboyd@chromium.org>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Colin Ian King <colin.king@canonical.com>,
Biju Das <biju.das@bp.renesas.com>,
Fabrizio Castro <fabrizio.castro@bp.renesas.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Yangtao Li <tiny.windzz@gmail.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2 05/13] usb: musb: create debugfs directory under usb root
Date: Thu, 14 Nov 2019 11:20:18 +0800 [thread overview]
Message-ID: <20191114032018.GA122287@kroah.com> (raw)
In-Reply-To: <20191112152857.GA5853@uda0271908>
On Tue, Nov 12, 2019 at 09:28:57AM -0600, Bin Liu wrote:
> Hi,
>
> On Tue, Nov 12, 2019 at 02:51:51PM +0800, Chunfeng Yun wrote:
> > Now the USB gadget subsystem can use the USB debugfs root directory,
> > so move musb's directory from the root of the debugfs filesystem into
> > the root of usb
>
> My opinion is this move is unnecessary. I breaks existing debug tools or
> documentation which is already published on Internet.
Having a "root" directory for a single random driver seems like you are
making your driver a "very important" thing in the overall scheme of the
kernel, right? What's wrong with using the usb subdirectory like all
other USB drivers use (after this patch series is merged)? That feels
like a much more "sane" way to handle the wide-open debugfs namespace.
Yes, there are no rules when it comes to debugfs file names and
locations, but let's try to be sane please.
thanks,
greg k-h
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2019-11-14 3:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 6:51 [PATCH v2 01/13] media: uvcvideo: drop error check of debugfs_create_dir() Chunfeng Yun
2019-11-12 6:51 ` [PATCH v2 02/13] usb: chipidea: debug: create debugfs directory under usb root Chunfeng Yun
2019-11-12 6:51 ` [PATCH v2 03/13] usb: host: imx21: " Chunfeng Yun
2019-11-12 6:51 ` [PATCH v2 04/13] usb: dwc3: " Chunfeng Yun
2019-11-12 6:51 ` [PATCH v2 05/13] usb: musb: " Chunfeng Yun
2019-11-12 15:28 ` Bin Liu
2019-11-14 3:20 ` Greg Kroah-Hartman [this message]
2019-11-14 14:02 ` Bin Liu
2019-11-15 3:21 ` Greg Kroah-Hartman
2019-11-15 13:45 ` Bin Liu
2019-11-12 6:51 ` [PATCH v2 06/13] usb: musb: dsps: " Chunfeng Yun
2019-11-12 6:51 ` [PATCH v2 07/13] usb: dwc2: " Chunfeng Yun
2019-11-12 6:51 ` [PATCH v2 08/13] usb: gadget: bcm63xx_udc: " Chunfeng Yun
2019-11-12 6:51 ` [PATCH v2 09/13] usb: gadget: atmel: " Chunfeng Yun
2019-11-12 6:51 ` [PATCH v2 10/13] usb: gadget: udc: renesas_usb3: " Chunfeng Yun
2019-11-12 6:51 ` [PATCH v2 11/13] usb: gadget: pxa27x: " Chunfeng Yun
2019-11-12 6:51 ` [PATCH v2 12/13] usb: gadget: udc: gr_udc: " Chunfeng Yun
2019-11-14 3:21 ` Greg Kroah-Hartman
2019-11-14 8:24 ` Chunfeng Yun
2019-11-12 6:51 ` [PATCH v2 13/13] usb: gadget: udc: s3c2410_udc: " Chunfeng Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191114032018.GA122287@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Peter.Chen@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=b-liu@ti.com \
--cc=balbi@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=biju.das@bp.renesas.com \
--cc=cernekee@gmail.com \
--cc=chunfeng.yun@mediatek.com \
--cc=colin.king@canonical.com \
--cc=cristian.birsan@microchip.com \
--cc=daniel@zonque.org \
--cc=f.fainelli@gmail.com \
--cc=fabrizio.castro@bp.renesas.com \
--cc=festevam@gmail.com \
--cc=gustavo@embeddedor.com \
--cc=haojian.zhuang@gmail.com \
--cc=hminas@synopsys.com \
--cc=kernel@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=robert.jarzmik@free.fr \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=swboyd@chromium.org \
--cc=tiny.windzz@gmail.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).