From: "Michal Koutný" <mkoutny@suse.com>
To: cgroups@vger.kernel.org
Cc: linger.lee@mediatek.com, tomcherry@google.com, shuah@kernel.org,
linux-kernel@vger.kernel.org, matthias.bgg@gmail.com,
Li Zefan <lizefan@huawei.com>,
linux-mediatek@lists.infradead.org,
linux-kselftest@vger.kernel.org,
Johannes Weiner <hannes@cmpxchg.org>, Tejun Heo <tj@kernel.org>,
alex.shi@linux.alibaba.com, kernel-team@android.com, guro@fb.com,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/3] cgroup: Iterate tasks that did not finish do_exit()
Date: Fri, 17 Jan 2020 16:15:30 +0100 [thread overview]
Message-ID: <20200117151533.12381-1-mkoutny@suse.com> (raw)
In-Reply-To: <20200116043612.52782-1-surenb@google.com>
Hi,
I was looking into the issue and came up with an alternative solution that
changes task iteration to be consistent with cgroup_is_populated() check and
moving the responsibility to check PF_EXITING on the consumers of iterator API.
I haven't check your approach thoroughly, however, it appears to me it
complicates (already non-trivial) cgroup destruction path. I ran your selftest
on the iterators approach and it proved working.
Michal Koutný (2):
cgroup: Unify css_set task lists
cgroup: Iterate tasks that did not finish do_exit()
Suren Baghdasaryan (1):
kselftest/cgroup: add cgroup destruction test
include/linux/cgroup-defs.h | 15 ++-
include/linux/cgroup.h | 4 +-
kernel/cgroup/cgroup.c | 86 ++++++++--------
kernel/cgroup/debug.c | 16 ++-
tools/testing/selftests/cgroup/test_core.c | 113 +++++++++++++++++++++
5 files changed, 176 insertions(+), 58 deletions(-)
--
2.24.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-01-17 15:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 4:36 [PATCH 1/2] cgroup: allow deletion of cgroups containing only dying processes Suren Baghdasaryan
2020-01-16 4:36 ` [PATCH 2/2] kselftest/cgroup: add cgroup destruction test Suren Baghdasaryan
2020-01-17 15:15 ` Michal Koutný [this message]
2020-01-17 15:15 ` [PATCH 1/3] cgroup: Unify css_set task lists Michal Koutný
2020-01-17 16:59 ` Tejun Heo
2020-01-17 15:15 ` [PATCH 2/3] cgroup: Iterate tasks that did not finish do_exit() Michal Koutný
2020-01-17 17:28 ` Tejun Heo
2020-01-17 18:41 ` Suren Baghdasaryan
2020-01-20 14:56 ` Michal Koutný
2020-01-24 11:40 ` [PATCH v2 0/3] " Michal Koutný
2020-01-24 11:40 ` [PATCH v2 1/3] " Michal Koutný
2020-01-24 22:56 ` Suren Baghdasaryan
2020-02-05 17:27 ` Suren Baghdasaryan
2020-02-12 22:03 ` Tejun Heo
2020-01-24 11:40 ` [PATCH v2 2/3] cgroup: Clean up css_set task traversal Michal Koutný
2020-01-24 11:40 ` [PATCH v2 3/3] kselftest/cgroup: add cgroup destruction test Michal Koutný
2020-02-12 22:10 ` Tejun Heo
2020-01-17 15:15 ` [PATCH " Michal Koutný
2020-01-17 17:30 ` [PATCH 0/3] cgroup: Iterate tasks that did not finish do_exit() Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117151533.12381-1-mkoutny@suse.com \
--to=mkoutny@suse.com \
--cc=alex.shi@linux.alibaba.com \
--cc=cgroups@vger.kernel.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@android.com \
--cc=linger.lee@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lizefan@huawei.com \
--cc=matthias.bgg@gmail.com \
--cc=shuah@kernel.org \
--cc=tj@kernel.org \
--cc=tomcherry@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).