From: Herbert Xu <herbert@gondor.apana.org.au>
To: Allen Pais <allen.lkml@gmail.com>
Cc: giovanni.cabiddu@intel.com, alexandre.belloni@bootlin.com,
aymen.sghaier@nxp.com, heiko@sntech.de, qat-linux@intel.com,
jamie@jamieiles.com, jesper.nilsson@axis.com,
linux-samsung-soc@vger.kernel.org, horia.geanta@nxp.com,
k.konieczny@samsung.com, schalla@marvell.com, krzk@kernel.org,
linux-rockchip@lists.infradead.org,
ludovic.desroches@microchip.com, thomas.lendacky@amd.com,
arno@natisbad.org, vz@mleia.com, gilad@benyossef.com,
gcherian@marvell.com, linux-mediatek@lists.infradead.org,
lars.persson@axis.com, matthias.bgg@gmail.com,
Allen Pais <apais@linux.microsoft.com>,
john.allen@amd.com, bbrezillon@kernel.org,
nicolas.ferre@microchip.com, linux-crypto@vger.kernel.org,
Romain Perier <romain.perier@gmail.com>,
davem@davemloft.net
Subject: Re: [PATCH v4 01/19] crypto: amcc: convert tasklets to use new tasklet_setup() API
Date: Fri, 29 Jan 2021 16:05:52 +1100 [thread overview]
Message-ID: <20210129050551.GA5586@gondor.apana.org.au> (raw)
In-Reply-To: <20210121044126.152274-2-allen.lkml@gmail.com>
On Thu, Jan 21, 2021 at 10:11:08AM +0530, Allen Pais wrote:
> From: Allen Pais <apais@linux.microsoft.com>
>
> In preparation for unconditionally passing the
> struct tasklet_struct pointer to all tasklet
> callbacks, switch to using the new tasklet_setup()
> and from_tasklet() to pass the tasklet pointer explicitly.
>
> Signed-off-by: Romain Perier <romain.perier@gmail.com>
> Signed-off-by: Allen Pais <apais@linux.microsoft.com>
> ---
> drivers/crypto/amcc/crypto4xx_core.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
This doesn't even compile:
CC [M] drivers/crypto/amcc/crypto4xx_core.o
CC [M] drivers/crypto/amcc/crypto4xx_alg.o
CC [M] drivers/crypto/amcc/crypto4xx_trng.o
CHECK ../drivers/crypto/amcc/crypto4xx_trng.c
../drivers/crypto/amcc/crypto4xx_core.c: In function ‘crypto4xx_cipher_done’:
../drivers/crypto/amcc/crypto4xx_core.c:526:13: warning: variable ‘addr’ set but not used [-Wunused-but-set-variable]
dma_addr_t addr;
^~~~
../drivers/crypto/amcc/crypto4xx_core.c: In function ‘crypto4xx_ahash_done’:
../drivers/crypto/amcc/crypto4xx_core.c:557:24: warning: variable ‘ctx’ set but not used [-Wunused-but-set-variable]
struct crypto4xx_ctx *ctx;
^~~
In file included from <command-line>:
../drivers/crypto/amcc/crypto4xx_core.c: In function ‘crypto4xx_bh_tasklet_cb’:
../include/linux/kernel.h:694:51: error: ‘struct device’ has no member named ‘tasklet’
BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
^~
./../include/linux/compiler_types.h:306:9: note: in definition of macro ‘__compiletime_assert’
if (!(condition)) \
^~~~~~~~~
./../include/linux/compiler_types.h:326:2: note: in expansion of macro ‘_compiletime_assert’
_compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
^~~~~~~~~~~~~~~~~~~
../include/linux/build_bug.h:39:37: note: in expansion of macro ‘compiletime_assert’
#define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
^~~~~~~~~~~~~~~~~~
../include/linux/kernel.h:694:2: note: in expansion of macro ‘BUILD_BUG_ON_MSG’
BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
^~~~~~~~~~~~~~~~
../include/linux/kernel.h:694:20: note: in expansion of macro ‘__same_type’
BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
^~~~~~~~~~~
../include/linux/interrupt.h:646:2: note: in expansion of macro ‘container_of’
container_of(callback_tasklet, typeof(*var), tasklet_fieldname)
^~~~~~~~~~~~
../drivers/crypto/amcc/crypto4xx_core.c:1078:23: note: in expansion of macro ‘from_tasklet’
struct device *dev = from_tasklet(dev, t, tasklet);
^~~~~~~~~~~~
./../include/linux/compiler_types.h:146:35: error: ‘struct device’ has no member named ‘tasklet’
#define __compiler_offsetof(a, b) __builtin_offsetof(a, b)
^~~~~~~~~~~~~~~~~~
../include/linux/stddef.h:17:32: note: in expansion of macro ‘__compiler_offsetof’
#define offsetof(TYPE, MEMBER) __compiler_offsetof(TYPE, MEMBER)
^~~~~~~~~~~~~~~~~~~
../include/linux/kernel.h:697:21: note: in expansion of macro ‘offsetof’
((type *)(__mptr - offsetof(type, member))); })
^~~~~~~~
../include/linux/interrupt.h:646:2: note: in expansion of macro ‘container_of’
container_of(callback_tasklet, typeof(*var), tasklet_fieldname)
^~~~~~~~~~~~
../drivers/crypto/amcc/crypto4xx_core.c:1078:23: note: in expansion of macro ‘from_tasklet’
struct device *dev = from_tasklet(dev, t, tasklet);
^~~~~~~~~~~~
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2021-01-29 5:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 4:41 [PATCH v4 00/19]crypto: convert tasklets to use new tasklet_setup API() Allen Pais
2021-01-21 4:41 ` [PATCH v4 01/19] crypto: amcc: convert tasklets to use new tasklet_setup() API Allen Pais
2021-01-29 5:05 ` Herbert Xu [this message]
2021-01-29 9:08 ` Allen Pais
2021-01-21 4:41 ` [PATCH v4 02/19] crypto: atmel: " Allen Pais
2021-01-21 4:41 ` [PATCH v4 03/19] crypto: axis: " Allen Pais
2021-01-21 4:41 ` [PATCH v4 04/19] crypto: caam: " Allen Pais
2021-01-21 4:41 ` [PATCH v4 05/19] crypto: cavium: " Allen Pais
2021-01-21 4:41 ` [PATCH v4 06/19] crypto: ccp: " Allen Pais
2021-01-21 4:41 ` [PATCH v4 07/19] crypto: ccree: " Allen Pais
2021-01-21 4:41 ` [PATCH v4 08/19] crypto: hifn_795x: " Allen Pais
2021-01-21 4:41 ` [PATCH v4 09/19] crypto: img-hash: " Allen Pais
2021-01-21 4:41 ` [PATCH v4 10/19] crypto: ixp4xx: " Allen Pais
2021-01-21 4:41 ` [PATCH v4 11/19] crypto: mediatek: " Allen Pais
2021-01-21 4:41 ` [PATCH v4 12/19] crypto: omap: " Allen Pais
2021-01-21 4:41 ` [PATCH v4 13/19] crypto: picoxcell: " Allen Pais
2021-01-21 4:41 ` [PATCH v4 14/19] crypto: qat: " Allen Pais
2021-01-21 4:41 ` [PATCH v4 15/19] crypto: qce: " Allen Pais
2021-01-21 4:41 ` [PATCH v4 16/19] crypto: rockchip: " Allen Pais
2021-01-21 4:41 ` [PATCH v4 17/19] crypto: s5p: " Allen Pais
2021-01-21 4:41 ` [PATCH v4 18/19] crypto: talitos: " Allen Pais
2021-01-21 4:41 ` [PATCH v4 19/19] crypto: octeontx: " Allen Pais
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210129050551.GA5586@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=alexandre.belloni@bootlin.com \
--cc=allen.lkml@gmail.com \
--cc=apais@linux.microsoft.com \
--cc=arno@natisbad.org \
--cc=aymen.sghaier@nxp.com \
--cc=bbrezillon@kernel.org \
--cc=davem@davemloft.net \
--cc=gcherian@marvell.com \
--cc=gilad@benyossef.com \
--cc=giovanni.cabiddu@intel.com \
--cc=heiko@sntech.de \
--cc=horia.geanta@nxp.com \
--cc=jamie@jamieiles.com \
--cc=jesper.nilsson@axis.com \
--cc=john.allen@amd.com \
--cc=k.konieczny@samsung.com \
--cc=krzk@kernel.org \
--cc=lars.persson@axis.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=matthias.bgg@gmail.com \
--cc=nicolas.ferre@microchip.com \
--cc=qat-linux@intel.com \
--cc=romain.perier@gmail.com \
--cc=schalla@marvell.com \
--cc=thomas.lendacky@amd.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).