From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Yong Wu <yong.wu@mediatek.com>, Joerg Roedel <joro@8bytes.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Will Deacon <will@kernel.org>
Cc: iommu@lists.linux-foundation.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, mingyuan.ma@mediatek.com,
yf.wang@mediatek.com, libo.kang@mediatek.com,
chengci.xu@mediatek.com, youlin.pei@mediatek.com,
anan.sun@mediatek.com, xueqi.zhang@mediatek.com,
Guenter Roeck <groeck@chromium.org>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v2 5/5] iommu/mediatek: Remove a unused "mapping" which is only for v1
Date: Thu, 16 Jun 2022 14:03:33 +0200 [thread overview]
Message-ID: <37676cad-bbe8-0e4b-6632-ab57d29bdb20@collabora.com> (raw)
In-Reply-To: <20220616054203.11365-6-yong.wu@mediatek.com>
Il 16/06/22 07:42, Yong Wu ha scritto:
> Just remove a unused variable that only is for mtk_iommu_v1.
>
> Fixes: 9485a04a5bb9 ("iommu/mediatek: Separate mtk_iommu_data for v1 and v2")
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
The title isn't immediately clear, looks like you're removing some mapping, not
a struct member...
Perhaps... iommu/mediatek: Remove unused "mapping" member from mtk_iommu_data ?
After clarifying the commit title:
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cheers,
Angelo
next prev parent reply other threads:[~2022-06-16 12:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 5:41 [PATCH v2 0/5] iommu/mediatek: Improve safety from dts Yong Wu
2022-06-16 5:41 ` [PATCH v2 1/5] iommu/mediatek: Use dev_err_probe to mute probe_defer err log Yong Wu
2022-06-16 13:28 ` Matthias Brugger
2022-06-16 5:42 ` [PATCH v2 2/5] iommu/mediatek: Add error path for loop of mm_dts_parse Yong Wu
2022-06-16 8:59 ` Robin Murphy
2022-06-16 10:08 ` Yong Wu
2022-06-16 10:31 ` Robin Murphy
2022-06-23 1:54 ` Yong Wu
2022-06-23 10:08 ` Robin Murphy
2022-06-16 13:49 ` Matthias Brugger
2022-06-23 2:12 ` Yong Wu
2022-06-16 5:42 ` [PATCH v2 3/5] iommu/mediatek: Validate number of phandles associated with "mediatek, larbs" Yong Wu
2022-06-16 5:42 ` [PATCH v2 4/5] iommu/mediatek: Improve safety for mediatek, smi property in larb nodes Yong Wu
2022-06-16 5:42 ` [PATCH v2 5/5] iommu/mediatek: Remove a unused "mapping" which is only for v1 Yong Wu
2022-06-16 12:03 ` AngeloGioacchino Del Regno [this message]
2022-06-16 13:56 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37676cad-bbe8-0e4b-6632-ab57d29bdb20@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=anan.sun@mediatek.com \
--cc=chengci.xu@mediatek.com \
--cc=dan.carpenter@oracle.com \
--cc=groeck@chromium.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=libo.kang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mingyuan.ma@mediatek.com \
--cc=will@kernel.org \
--cc=xueqi.zhang@mediatek.com \
--cc=yf.wang@mediatek.com \
--cc=yong.wu@mediatek.com \
--cc=youlin.pei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).