From: Lukasz Luba <lukasz.luba@arm.com>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-imx@nxp.com
Cc: nm@ti.com, juri.lelli@redhat.com, peterz@infradead.org,
viresh.kumar@linaro.org, bjorn.andersson@linaro.org,
bsegall@google.com, festevam@gmail.com, Morten.Rasmussen@arm.com,
robh@kernel.org, amit.kucheria@verdurent.com,
vincent.guittot@linaro.org, khilman@kernel.org,
daniel.lezcano@linaro.org, steven.price@arm.com,
cw00.choi@samsung.com, mingo@redhat.com, mgorman@suse.de,
rui.zhang@intel.com, alyssa.rosenzweig@collabora.com,
daniel@ffwll.ch, b.zolnierkie@samsung.com,
s.hauer@pengutronix.de, rostedt@goodmis.org,
matthias.bgg@gmail.com, Chris.Redpath@arm.com, airlied@linux.ie,
javi.merino@arm.com, tomeu.vizoso@collabora.com,
qperret@google.com, sboyd@kernel.org, shawnguo@kernel.org,
rjw@rjwysocki.net, agross@kernel.org, kernel@pengutronix.de,
sudeep.holla@arm.com, patrick.bellasi@matbug.net,
ionela.voinescu@arm.com
Subject: Re: [PATCH 1/4] PM / EM: and devices to Energy Model
Date: Mon, 20 Jan 2020 15:36:46 +0000 [thread overview]
Message-ID: <38307e88-f7ff-bc2a-bbce-5e508e275526@arm.com> (raw)
In-Reply-To: <d0b90b97-3604-d4f4-b873-3879a9221532@arm.com>
On 1/20/20 3:11 PM, Dietmar Eggemann wrote:
> On 20/01/2020 15:53, Dietmar Eggemann wrote:
>> On 16/01/2020 16:20, lukasz.luba@arm.com wrote:
>>> From: Lukasz Luba <lukasz.luba@arm.com>
>
> [...]
>
>>> +enum em_type {
>>> + EM_SIMPLE,
>>> + EM_CPU,
>>> +};
>>
>> s/EM_SIMPLE/EM_DEV ?
>>
>> Right now I only see energy models and _one_ specific type (the CPU EM).
>> So a tag 'is a CPU EM' would suffice. No need for EM_SIMPE ...
>
> Wait, you even have
>
> struct em_device {
> struct em_perf_domain *em_pd;
> struct device *dev;
> ...
> }
>
> static bool _is_cpu_device(struct device *dev)
>
> Shouldn't this be enough to distinguish between EM and special CPU EM
> under the API? Even when required to use container_of() to get from
> em_perf_domain to device.
>
Agree, I will remove this em_type related code.
Lukasz
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-01-20 15:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 15:20 [PATCH 0/4] Add support for devices in the Energy Model lukasz.luba
2020-01-16 15:20 ` [PATCH 1/4] PM / EM: and devices to " lukasz.luba
2020-01-17 10:54 ` Quentin Perret
2020-01-20 14:52 ` Lukasz Luba
2020-01-20 15:09 ` Quentin Perret
2020-01-20 18:27 ` Dietmar Eggemann
2020-01-20 18:38 ` Lukasz Luba
2020-01-21 9:10 ` Dietmar Eggemann
2020-01-21 9:37 ` Quentin Perret
2020-01-21 9:31 ` Quentin Perret
2020-01-20 14:53 ` Dietmar Eggemann
2020-01-20 15:11 ` Dietmar Eggemann
2020-01-20 15:36 ` Lukasz Luba [this message]
2020-01-20 15:27 ` Lukasz Luba
2020-01-20 15:28 ` Quentin Perret
2020-01-20 16:20 ` Lukasz Luba
2020-01-21 10:08 ` Quentin Perret
2020-01-21 10:49 ` Lukasz Luba
2020-01-16 15:20 ` [PATCH 2/4] OPP: change parameter to device pointer in dev_pm_opp_of_register_em() lukasz.luba
2020-01-16 15:20 ` [PATCH 3/4] thermal: devfreq_cooling: Refactor code and switch to use Energy Model lukasz.luba
2020-01-21 17:11 ` Steven Rostedt
2020-01-22 9:35 ` Lukasz Luba
2020-01-16 15:20 ` [PATCH 4/4] drm/panfrost: Register to the Energy Model with devfreq device lukasz.luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38307e88-f7ff-bc2a-bbce-5e508e275526@arm.com \
--to=lukasz.luba@arm.com \
--cc=Chris.Redpath@arm.com \
--cc=Morten.Rasmussen@arm.com \
--cc=agross@kernel.org \
--cc=airlied@linux.ie \
--cc=alyssa.rosenzweig@collabora.com \
--cc=amit.kucheria@verdurent.com \
--cc=b.zolnierkie@samsung.com \
--cc=bjorn.andersson@linaro.org \
--cc=bsegall@google.com \
--cc=cw00.choi@samsung.com \
--cc=daniel.lezcano@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dietmar.eggemann@arm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=ionela.voinescu@arm.com \
--cc=javi.merino@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kernel@pengutronix.de \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=nm@ti.com \
--cc=patrick.bellasi@matbug.net \
--cc=peterz@infradead.org \
--cc=qperret@google.com \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
--cc=rostedt@goodmis.org \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=steven.price@arm.com \
--cc=sudeep.holla@arm.com \
--cc=tomeu.vizoso@collabora.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).