From: Matthias Brugger <matthias.bgg@gmail.com>
To: Bibby Hsieh <bibby.hsieh@mediatek.com>,
Jassi Brar <jassisinghbrar@gmail.com>,
Rob Herring <robh+dt@kernel.org>, CK HU <ck.hu@mediatek.com>
Cc: devicetree@vger.kernel.org,
Nicolas Boichat <drinkcat@chromium.org>,
srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org,
Houlong Wei <houlong.wei@mediatek.com>,
Dennis-YC Hsieh <dennis-yc.hsieh@mediatek.com>,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] dt-binding: gce: remove atomic_exec in mboxes property
Date: Fri, 14 Feb 2020 11:30:01 +0100 [thread overview]
Message-ID: <7cca2ac2-258b-0bc9-a9fe-92c8dc430e3f@gmail.com> (raw)
In-Reply-To: <20200214043325.16618-4-bibby.hsieh@mediatek.com>
On 14/02/2020 05:33, Bibby Hsieh wrote:
> There is not any client driver using this feature now,
> so remove it from binding.
>
> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> ---
> Documentation/devicetree/bindings/mailbox/mtk-gce.txt | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> index 7b13787ab13d..0b5b2a6bcc48 100644
> --- a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> +++ b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> @@ -14,13 +14,11 @@ Required properties:
> - interrupts: The interrupt signal from the GCE block
> - clock: Clocks according to the common clock binding
> - clock-names: Must be "gce" to stand for GCE clock
> -- #mbox-cells: Should be 3.
> - <&phandle channel priority atomic_exec>
> +- #mbox-cells: Should be 2.
> + <&phandle channel priority>
Normally we will need to support backwards compatibility for three cells. As we
don't have a consumer of the mailbox interface for now, I think we are fine
without providing atomic_exec in the driver and the DT.
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Ah, by the way. Please beware that devicetree maintainer prefer to have the
binding changes in the first patch of a series, as it makes their live easier.
Regards,
Matthias
> phandle: Label name of a gce node.
> channel: Channel of mailbox. Be equal to the thread id of GCE.
> priority: Priority of GCE thread.
> - atomic_exec: GCE processing continuous packets of commands in atomic
> - way.
>
> Required properties for a client device:
> - mboxes: Client use mailbox to communicate with GCE, it should have this
> @@ -54,8 +52,8 @@ Example for a client device:
>
> mmsys: clock-controller@14000000 {
> compatible = "mediatek,mt8173-mmsys";
> - mboxes = <&gce 0 CMDQ_THR_PRIO_LOWEST 1>,
> - <&gce 1 CMDQ_THR_PRIO_LOWEST 1>;
> + mboxes = <&gce 0 CMDQ_THR_PRIO_LOWEST>,
> + <&gce 1 CMDQ_THR_PRIO_LOWEST>;
> mutex-event-eof = <CMDQ_EVENT_MUTEX0_STREAM_EOF
> CMDQ_EVENT_MUTEX1_STREAM_EOF>;
> mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0x3000 0x1000>,
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
prev parent reply other threads:[~2020-02-14 10:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 4:33 [PATCH 0/3] Remove atomic_exec Bibby Hsieh
2020-02-14 4:33 ` [PATCH 1/3] mailbox: mediatek: implement flush function Bibby Hsieh
2020-02-14 5:53 ` CK Hu
2020-02-14 4:33 ` [PATCH 2/3] mailbox: mediatek: remove implementation related to atomic_exec Bibby Hsieh
2020-02-14 5:54 ` CK Hu
2020-02-14 4:33 ` [PATCH 3/3] dt-binding: gce: remove atomic_exec in mboxes property Bibby Hsieh
2020-02-14 5:05 ` CK Hu
2020-02-14 10:30 ` Matthias Brugger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cca2ac2-258b-0bc9-a9fe-92c8dc430e3f@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=bibby.hsieh@mediatek.com \
--cc=ck.hu@mediatek.com \
--cc=dennis-yc.hsieh@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=houlong.wei@mediatek.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).