From: Kalle Valo <kvalo@codeaurora.org>
To: Ryder Lee <ryder.lee@mediatek.com>
Cc: Felix Fietkau <nbd@nbd.name>,
Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
Shayne Chen <shayne.chen@mediatek.com>,
Evelyn Tsai <evelyn.tsai@mediatek.com>,
<linux-wireless@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH 2/4] mt76: mt7615: checkpatch cleanup
Date: Sat, 21 Aug 2021 13:08:49 +0300 [thread overview]
Message-ID: <8735r3un2m.fsf@codeaurora.org> (raw)
In-Reply-To: <45c67ffb65debdd62a417c0b68af2ba7f1932195.camel@mediatek.com> (Ryder Lee's message of "Fri, 20 Aug 2021 09:29:00 +0800")
Ryder Lee <ryder.lee@mediatek.com> writes:
> On Thu, 2021-08-19 at 18:32 +0300, Kalle Valo wrote:
>> Ryder Lee <ryder.lee@mediatek.com> writes:
>>
>> > Fix reasonable checkpatch warnings.
>> >
>> > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
>>
>> One logical change per patch, please.
>
> I prefer collection all checkpatch warnings into the single patch.
But in upstream we prefer one logical change per patch, for example
makes it a lot easier to review and bisect.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2021-08-21 10:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-07 3:14 [PATCH 1/4] mt76: mt7915: checkpatch cleanup Ryder Lee
2021-08-07 3:14 ` [PATCH 2/4] mt76: mt7615: " Ryder Lee
2021-08-19 15:32 ` Kalle Valo
2021-08-20 1:29 ` Ryder Lee
2021-08-21 10:08 ` Kalle Valo [this message]
2021-08-07 3:14 ` [PATCH 3/4] mt76: mt7915: add HE-LTF into fixed rate command Ryder Lee
2021-08-07 3:14 ` [PATCH 4/4] mt76: mt7915: introduce mt7915_mcu_beacon_check_caps() Ryder Lee
2021-08-19 15:32 ` [PATCH 1/4] mt76: mt7915: checkpatch cleanup Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735r3un2m.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=evelyn.tsai@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
--cc=ryder.lee@mediatek.com \
--cc=shayne.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).