From: Hsin-Yi Wang <hsinyi@chromium.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Nicolas Boichat <drinkcat@chromium.org>,
lkml <linux-kernel@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Collabora Kernel ML <kernel@collabora.com>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] soc: mediatek: pm-domains: Don't print an error if child domain is deferred
Date: Thu, 14 Jan 2021 12:00:18 +0800 [thread overview]
Message-ID: <CAJMQK-gvKaiHNWxzq3+NDnoN8kd2u26e6WKZqX=R9dc+aB5xFw@mail.gmail.com> (raw)
In-Reply-To: <20210113213012.67643-1-enric.balletbo@collabora.com>
On Thu, Jan 14, 2021 at 5:30 AM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> Child domains can be deferred by the core because one of its resources
> is not available yet, in such case, it will print an error, but
> later it will succeed to probe. Fix that using the dev_err_probe()
> function so it only prints an error on a real error.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
>
> drivers/soc/mediatek/mtk-pm-domains.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-pm-domains.c b/drivers/soc/mediatek/mtk-pm-domains.c
> index ae255aa7b1a9..8055fb019ba6 100644
> --- a/drivers/soc/mediatek/mtk-pm-domains.c
> +++ b/drivers/soc/mediatek/mtk-pm-domains.c
> @@ -480,8 +480,8 @@ static int scpsys_add_subdomain(struct scpsys *scpsys, struct device_node *paren
>
> child_pd = scpsys_add_one_domain(scpsys, child);
> if (IS_ERR(child_pd)) {
> - ret = PTR_ERR(child_pd);
> - dev_err(scpsys->dev, "%pOF: failed to get child domain id\n", child);
> + dev_err_probe(scpsys->dev, PTR_ERR(child_pd),
> + "%pOF: failed to get child domain id\n", child);
> goto err_put_node;
> }
>
> --
> 2.29.2
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2021-01-14 4:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 21:30 [PATCH] soc: mediatek: pm-domains: Don't print an error if child domain is deferred Enric Balletbo i Serra
2021-01-14 4:00 ` Hsin-Yi Wang [this message]
2021-01-31 14:59 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJMQK-gvKaiHNWxzq3+NDnoN8kd2u26e6WKZqX=R9dc+aB5xFw@mail.gmail.com' \
--to=hsinyi@chromium.org \
--cc=drinkcat@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).