From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DA5AC33CAB for ; Mon, 13 Jan 2020 06:44:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FF3B214D8 for ; Mon, 13 Jan 2020 06:44:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="X9q51GJL"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="OyvIPxXK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1FF3B214D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DbBDxEqncHYzf13HgmfPRR8J4R4MELzplo2HjWK2Pig=; b=X9q51GJLtZfkJY 8+LHY8OqPq57ciawDbVWVbTU47BBjlKgQKMZRR2+UAK7hxlUB/N/sEt/mhfLmOM7TkNP8aejYzkEY lnSfIKFj52AAP4iOJ1EFMZQzRYppv00auDnUaFvVUypsYUadjGPgpamrK71IrLMVA0cvDzypMSqtj v8HcKK3MlW38hHURTg3Lth9oU0o/AH3myJ66c3JHDInNK/WSz1WrWEw4Qglot+89tmmYR7NY66xmv m8x/TUhoqdqG4CHa5OglBVfP7Ex3tEoQ7l3s0rfsp+r7T4LoE5OZGRI3iq+Grd81X3uoZOv2pjytF iKY6no2gnedlAZXGrk7A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iqtSf-00058C-KO; Mon, 13 Jan 2020 06:44:29 +0000 Received: from mail-qk1-x741.google.com ([2607:f8b0:4864:20::741]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iqtSV-0004yr-9s for linux-mediatek@lists.infradead.org; Mon, 13 Jan 2020 06:44:20 +0000 Received: by mail-qk1-x741.google.com with SMTP id c17so7562217qkg.7 for ; Sun, 12 Jan 2020 22:44:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BNID1+xlk/LusKrfyvTRadaTjl4JTdHdZqFClmlrkE8=; b=OyvIPxXK+9gRKfh1j2g/pw9Okrn9nsbKhZjAf9nvWrFWTasOHoycaN/UYYMfhcIC19 q7V2LwdxqeCs4zYNYujxCALeZwUnxdGHWOyse3uCMcKGt+LjGnSL1M0bpUfxgD4n2fec c1TWiw/luhrhXoyB6w/D1tFMJi+V+IvKJEasQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BNID1+xlk/LusKrfyvTRadaTjl4JTdHdZqFClmlrkE8=; b=N0N2sbdKUI1JebnXPilwv9m2Y61v+8hTTIVT3//wRYL9hp3pdGlmv4fXBktX2Af4pR ZdjjL4qPZUi9Y1XUJrRXt1N6g7xRhZyR03hy9q/8PElftNbG9AZrP4UF52rDZ85N/YUj TjEUoYhHBFfEXONJAE1zrFnPJ15AAupou+V6w+kT5YkZYVxBVKfn5VlQ5IHbsQlp2jk5 zGaWFp4wEOXVE/wdk/jdPgRWki4OYEdtUJC5niLffNU0CgEC/UmX6G61XYOqYcYhdjnR mYH3qUQxGxmet3mdcIA5Z4uNnQ00hpIZUENAVjbsLpJicQKsI9eCePQlP/fE9CBsy52B n5mw== X-Gm-Message-State: APjAAAVLNfMvxInto5sHTlHuMpuuIejBEP3hiXGHy6ND7d3+WnS+3DXb Zye/nCIuiGhnNAsCzi1VyNkGCTe8Gh8XY/+9uufE+g== X-Google-Smtp-Source: APXvYqzL5B5r73soR628uc2jDkq8fU1OUh+0wVt0KMcWK9cN8MbW5ohquaKM4R+Ks/ACv40A/WWnmnHJYeJHxhoohe8= X-Received: by 2002:a05:620a:6d7:: with SMTP id 23mr14117387qky.299.1578897858106; Sun, 12 Jan 2020 22:44:18 -0800 (PST) MIME-Version: 1.0 References: <20200107070154.1574-1-roger.lu@mediatek.com> <20200107070154.1574-2-roger.lu@mediatek.com> <20200108203829.GA18987@bogus> In-Reply-To: <20200108203829.GA18987@bogus> From: Nicolas Boichat Date: Mon, 13 Jan 2020 14:44:07 +0800 Message-ID: Subject: Re: [PATCH v6 1/3] dt-bindings: soc: add mtk svs dt-bindings To: Rob Herring X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200112_224419_368637_AB98793A X-CRM114-Status: GOOD ( 19.88 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Nicolas Boichat , Angus Lin , Kevin Hilman , Stephen Boyd , linux-pm@vger.kernel.org, Roger Lu , lkml , HenryC Chen , YT Lee , Fan Chen , Devicetree List , "moderated list:ARM/Mediatek SoC support" , Xiaoqing Liu , Charles Yang , Matthias Brugger , Nishanth Menon , linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, Jan 9, 2020 at 4:38 AM Rob Herring wrote: > > On Tue, Jan 07, 2020 at 03:01:52PM +0800, Roger Lu wrote: > > Document the binding for enabling mtk svs on MediaTek SoC. > > > > Signed-off-by: Roger Lu > > --- > > .../devicetree/bindings/power/mtk-svs.txt | 76 +++++++++++++++++++ > > 1 file changed, 76 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/power/mtk-svs.txt > > > > diff --git a/Documentation/devicetree/bindings/power/mtk-svs.txt b/Documentation/devicetree/bindings/power/mtk-svs.txt > > new file mode 100644 > > index 000000000000..9a3e81b9e1d2 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/power/mtk-svs.txt > > @@ -0,0 +1,76 @@ > > +* Mediatek Smart Voltage Scaling (MTK SVS) > > + > > +This describes the device tree binding for the MTK SVS controller (bank) > > +which helps provide the optimized CPU/GPU/CCI voltages. This device also > > +needs thermal data to calculate thermal slope for accurately compensate > > +the voltages when temperature change. > > + > > +Required properties: > > +- compatible: > > + - "mediatek,mt8183-svs" : For MT8183 family of SoCs > > +- reg: Address range of the MTK SVS controller. > > +- interrupts: IRQ for the MTK SVS controller. > > +- clocks, clock-names: Clocks needed for the svs hardware. required > > + clocks are: > > + "main": Main clock for svs controller to work. > > +- nvmem-cells: Phandle to the calibration data provided by a nvmem device. > > +- nvmem-cell-names: Should be "svs-calibration-data" and "calibration-data" > > + > > +Subnodes: > > +- svs-cpu-little: SVS bank device node of little CPU > > + compatible: "mediatek,mt8183-svs-cpu-little" > > + operating-points-v2: OPP table hooked by SVS little CPU bank. > > + SVS will optimze this OPP table voltage part. > > + vcpu-little-supply: PMIC buck of little CPU > > +- svs-cpu-big: SVS bank device node of big CPU > > + compatible: "mediatek,mt8183-svs-cpu-big" > > + operating-points-v2: OPP table hooked by SVS big CPU bank. > > + SVS will optimze this OPP table voltage part. > > + vcpu-big-supply: PMIC buck of big CPU > > +- svs-cci: SVS bank device node of CCI > > + compatible: "mediatek,mt8183-svs-cci" > > + operating-points-v2: OPP table hooked by SVS CCI bank. > > + SVS will optimze this OPP table voltage part. > > + vcci-supply: PMIC buck of CCI > > +- svs-gpu: SVS bank device node of GPU > > + compatible: "mediatek,mt8183-svs-gpu" > > + operating-points-v2: OPP table hooked by SVS GPU bank. > > + SVS will optimze this OPP table voltage part. > > + vgpu-supply: PMIC buck of GPU > > + > > +Example: > > + > > + svs: svs@1100b000 { > > + compatible = "mediatek,mt8183-svs"; > > + reg = <0 0x1100b000 0 0x1000>; > > + interrupts = ; > > + clocks = <&infracfg CLK_INFRA_THERM>; > > + clock-names = "main_clk"; > > + nvmem-cells = <&svs_calibration>, <&thermal_calibration>; > > + nvmem-cell-names = "svs-calibration-data", "calibration-data"; > > + > > + svs_cpu_little: svs-cpu-little { > > + compatible = "mediatek,mt8183-svs-cpu-little"; > > + operating-points-v2 = <&cluster0_opp>; > > + vcpu-little-supply = <&mt6358_vproc12_reg>; > > + }; > > I don't think this is a good binding. This information already exists > elsewhere in the DT, so your driver should just look in those nodes. > For example the regulator can be in the cpu nodes or the OPP table > itself. Roger, if that helps, without changing any other binding, on 8183, basically you could have: - svs-cpu-little: Add a handle to &cpu0 and get the regulator/opp table from it. - svs-cpu-big: Handle to &cpu4 - svs-cci: Handle to &cci - svs-gpu: Handle to &gpu (BTW, it is expected that SVS would only apply to vgpu/mali regulator, and not vsram regulator?) I'm not too sure how we'd fetch the right regulator name, however (for the first 3 the name is "proc", for the last one it's "mali"), maybe add a regulator-name list in the DT? > > Rob _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek