From: Mark Brown <broonie@kernel.org>
To: Alexandre Mergnat <amergnat@baylibre.com>
Cc: Lee Jones <lee@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Chen Zhong <chen.zhong@mediatek.com>,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Rob Herring <robh@kernel.org>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
Fabien Parent <fparent@baylibre.com>
Subject: Re: [PATCH v2 4/5] regulator: add mt6357 regulator
Date: Wed, 5 Oct 2022 16:09:22 +0100 [thread overview]
Message-ID: <Yz2eIslwcXKNaOfi@sirena.org.uk> (raw)
In-Reply-To: <20221005-mt6357-support-v2-4-f17ba2d2d0a9@baylibre.com>
[-- Attachment #1: Type: text/plain, Size: 611 bytes --]
On Wed, Oct 05, 2022 at 04:57:24PM +0200, Alexandre Mergnat wrote:
> +static int mt6357_set_voltage_sel(struct regulator_dev *rdev,
> + unsigned int selector)
> +{
> + int idx, ret;
> + const u32 *pvol;
> + struct mt6357_regulator_info *info = rdev_get_drvdata(rdev);
> +
> + pvol = info->index_table;
> +
> + idx = pvol[selector];
> + ret = regmap_update_bits(rdev->regmap, info->desc.vsel_reg,
> + info->desc.vsel_mask,
> + idx << 8);
> +
> + return ret;
> +}
There's a bunch of other Mediatek drivers doing this and multiple
instances in this driver, the helper should really be factored out.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-10-05 15:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 14:57 [PATCH v2 0/5] Add MediaTek MT6357 PMIC support Alexandre Mergnat
2022-10-05 14:57 ` [PATCH v2 1/5] dt-bindings: mfd: mt6397: add binding for MT6357 Alexandre Mergnat
2022-10-24 12:51 ` Lee Jones
2022-10-05 14:57 ` [PATCH v2 2/5] dt-bindings: input: mtk-pmic-keys: add binding for MT6357 PMIC Alexandre Mergnat
2022-10-10 18:03 ` Dmitry Torokhov
2022-10-05 14:57 ` [PATCH v2 3/5] dt-bindings: regulator: Add binding schema for mt6357 regulators Alexandre Mergnat
2022-10-05 16:02 ` Krzysztof Kozlowski
2022-10-11 9:30 ` Alexandre Mergnat
2022-10-11 10:36 ` Mark Brown
2022-10-11 12:03 ` Krzysztof Kozlowski
2022-10-05 14:57 ` [PATCH v2 4/5] regulator: add mt6357 regulator Alexandre Mergnat
2022-10-05 15:09 ` Mark Brown [this message]
2022-10-06 10:12 ` AngeloGioacchino Del Regno
2022-10-05 14:57 ` [PATCH v2 5/5] Input: mtk-pmic-keys: add MT6357 support Alexandre Mergnat
2022-10-06 7:40 ` Mattijs Korpershoek
2022-10-06 10:12 ` AngeloGioacchino Del Regno
2022-10-10 18:04 ` Dmitry Torokhov
2022-10-24 12:50 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yz2eIslwcXKNaOfi@sirena.org.uk \
--to=broonie@kernel.org \
--cc=amergnat@baylibre.com \
--cc=chen.zhong@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=fparent@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).