From: Matthias Brugger <matthias.bgg@gmail.com>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>,
Kishon Vijay Abraham I <kishon@ti.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND PATCH v5 11/11] arm64: dts: mt2712: use non-empty ranges for usb-phy
Date: Sat, 16 May 2020 17:35:18 +0200 [thread overview]
Message-ID: <dbeb21d5-ece6-5a09-4802-ad5ba3d2b21a@gmail.com> (raw)
In-Reply-To: <0b039294697126edb25a699b8c25b7fcc84eed36.1581389234.git.chunfeng.yun@mediatek.com>
On 11/02/2020 04:21, Chunfeng Yun wrote:
> Use non-empty ranges for usb-phy to make the layout of
> its registers clearer;
> Replace deprecated compatible by generic
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
queued for v5.7-next/dts64
Thanks a lot
> ---
> v3~v5: no changes
>
> v2: use generic compatible
> ---
> arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 42 ++++++++++++-----------
> 1 file changed, 22 insertions(+), 20 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
> index 43307bad3f0d..e24f2f2f6004 100644
> --- a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
> @@ -697,30 +697,31 @@ usb_host0: xhci@11270000 {
> };
>
> u3phy0: usb-phy@11290000 {
> - compatible = "mediatek,mt2712-u3phy";
> - #address-cells = <2>;
> - #size-cells = <2>;
> - ranges;
> + compatible = "mediatek,mt2712-tphy",
> + "mediatek,generic-tphy-v2";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0 0 0x11290000 0x9000>;
> status = "okay";
>
> - u2port0: usb-phy@11290000 {
> - reg = <0 0x11290000 0 0x700>;
> + u2port0: usb-phy@0 {
> + reg = <0x0 0x700>;
> clocks = <&clk26m>;
> clock-names = "ref";
> #phy-cells = <1>;
> status = "okay";
> };
>
> - u2port1: usb-phy@11298000 {
> - reg = <0 0x11298000 0 0x700>;
> + u2port1: usb-phy@8000 {
> + reg = <0x8000 0x700>;
> clocks = <&clk26m>;
> clock-names = "ref";
> #phy-cells = <1>;
> status = "okay";
> };
>
> - u3port0: usb-phy@11298700 {
> - reg = <0 0x11298700 0 0x900>;
> + u3port0: usb-phy@8700 {
> + reg = <0x8700 0x900>;
> clocks = <&clk26m>;
> clock-names = "ref";
> #phy-cells = <1>;
> @@ -760,30 +761,31 @@ usb_host1: xhci@112c0000 {
> };
>
> u3phy1: usb-phy@112e0000 {
> - compatible = "mediatek,mt2712-u3phy";
> - #address-cells = <2>;
> - #size-cells = <2>;
> - ranges;
> + compatible = "mediatek,mt2712-tphy",
> + "mediatek,generic-tphy-v2";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0 0 0x112e0000 0x9000>;
> status = "okay";
>
> - u2port2: usb-phy@112e0000 {
> - reg = <0 0x112e0000 0 0x700>;
> + u2port2: usb-phy@0 {
> + reg = <0x0 0x700>;
> clocks = <&clk26m>;
> clock-names = "ref";
> #phy-cells = <1>;
> status = "okay";
> };
>
> - u2port3: usb-phy@112e8000 {
> - reg = <0 0x112e8000 0 0x700>;
> + u2port3: usb-phy@8000 {
> + reg = <0x8000 0x700>;
> clocks = <&clk26m>;
> clock-names = "ref";
> #phy-cells = <1>;
> status = "okay";
> };
>
> - u3port1: usb-phy@112e8700 {
> - reg = <0 0x112e8700 0 0x900>;
> + u3port1: usb-phy@8700 {
> + reg = <0x8700 0x900>;
> clocks = <&clk26m>;
> clock-names = "ref";
> #phy-cells = <1>;
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-05-16 15:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 3:21 [RESEND PATCH v5 01/11] dt-bindings: phy-mtk-tphy: add two optional properties for u2phy Chunfeng Yun
2020-02-11 3:21 ` [RESEND PATCH v5 02/11] dt-bindings: phy-mtk-tphy: make the ref clock optional Chunfeng Yun
2020-02-11 3:21 ` [RESEND PATCH v5 03/11] dt-bindings: phy-mtk-tphy: remove unused u3phya_ref clock Chunfeng Yun
2020-02-11 3:21 ` [RESEND PATCH v5 04/11] dt-bindings: phy-mtk-tphy: add a new reference clock Chunfeng Yun
2020-02-11 3:21 ` [RESEND PATCH v5 05/11] dt-bindings: phy-mtk-tphy: add the properties about address mapping Chunfeng Yun
2020-02-11 3:21 ` [RESEND PATCH v5 06/11] phy: phy-mtk-tphy: add a property for disconnect threshold Chunfeng Yun
2020-02-11 3:21 ` [RESEND PATCH v5 07/11] phy: phy-mtk-tphy: add a property for internal resistance Chunfeng Yun
2020-02-11 3:21 ` [RESEND PATCH v5 08/11] phy: phy-mtk-tphy: make the ref clock optional Chunfeng Yun
2020-02-11 3:21 ` [RESEND PATCH v5 09/11] phy: phy-mtk-tphy: remove unused u3phya_ref clock Chunfeng Yun
2020-02-11 3:21 ` [RESEND PATCH v5 10/11] phy: phy-mtk-tphy: add a new reference clock Chunfeng Yun
2020-02-11 3:21 ` [RESEND PATCH v5 11/11] arm64: dts: mt2712: use non-empty ranges for usb-phy Chunfeng Yun
2020-05-16 15:35 ` Matthias Brugger [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-01-08 1:51 [RESEND PATCH v5 01/11] dt-bindings: phy-mtk-tphy: add two optional properties for u2phy Chunfeng Yun
2020-01-08 1:52 ` [RESEND PATCH v5 11/11] arm64: dts: mt2712: use non-empty ranges for usb-phy Chunfeng Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbeb21d5-ece6-5a09-4802-ad5ba3d2b21a@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).