Re: [PATCH 19/19] arm64: vdso32: Enable Clang Compilation

From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Will Deacon <will@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	0x7f454c46@gmail.com, linux-mips@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-arch <linux-arch@vger.kernel.org>,
	the arch/x86 maintainers <x86@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	clang-built-linux <clang-built-linux@googlegroups.com>,
	Ingo Molnar <mingo@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
	Will Deacon <will.deacon@arm.com>, Borislav Petkov <bp@alien8.de>,
	Andy Lutomirski <luto@kernel.org>,
	Nathan Chancellor <natechancellor@gmail.com>,
	pcc@google.com,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	avagin@openvz.org, Stephen Boyd <sboyd@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	salyzyn@android.com, Paul Burton <paul.burton@mips.com>
Subject: Re: [PATCH 19/19] arm64: vdso32: Enable Clang Compilation
Date: Tue, 18 Feb 2020 13:03:55 +0000	[thread overview]
Message-ID: <19afd7ed-9a90-1d31-8cc6-33645cf8d3ec@arm.com> (raw)
In-Reply-To: <CAKv+Gu8Qh495twz-3UQrFiKfPq-Kt_o+JrCNwEcdMedV2DqPEA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1745 bytes --]

On 17/02/2020 22:39, Ard Biesheuvel wrote:
> On Mon, 17 Feb 2020 at 17:46, Will Deacon <will@kernel.org> wrote:
>>
>> On Mon, Feb 17, 2020 at 12:26:16PM +0000, Vincenzo Frascino wrote:
>>> On 13/02/2020 18:44, Nathan Chancellor wrote:
>>>> On Thu, Feb 13, 2020 at 04:16:14PM +0000, Vincenzo Frascino wrote:
>>>>> Enable Clang Compilation for the vdso32 library.
>>>
>>> [...]
>>>
>>>>> +LD_COMPAT ?= $(CROSS_COMPILE_COMPAT)gcc
>>>>
>>>> Well this is unfortunate :/
>>>>
>>>> It looks like adding the --target flag to VDSO_LDFLAGS allows
>>>> clang to link the vDSO just fine although it does warn that -nostdinc
>>>> is unused:
>>>>
>>>> clang-11: warning: argument unused during compilation: '-nostdinc'
>>>> [-Wunused-command-line-argument]
>>>>
>>>
>>> This is why ended up in this "unfortunate" situation :) I wanted to avoid the
>>> warning.
>>>
>>>> It would be nice if the logic of commit fe00e50b2db8 ("ARM: 8858/1:
>>>> vdso: use $(LD) instead of $(CC) to link VDSO") could be adopted here
>>>> but I get that this Makefile is its own beast :) at the very least, I
>>>> think that the --target flag should be added to VDSO_LDFLAGS so that gcc
>>>> is not a requirement for this but I am curious if you tried that already
>>>> and noticed any issues with it.
>>>>
>>>
>>> --target is my preferred way as well, I can try to play another little bit with
>>> the flags and see what I can come up with in the next version.
>>
>> Yes, please. I'd even prefer the warning rather than silently assuming that
>> a cross gcc is kicking around on the path.
>>
> 
> Doesn't Clang have -Qunused-arguments for that?
> 

Yes, this is exactly what I was looking for. Thanks Ard :)

-- 
Regards,
Vincenzo

[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 14291 bytes --]