linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Burton <paul.burton@mips.com>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
	"keguang.zhang@gmail.com" <keguang.zhang@gmail.com>
Subject: Re: [PATCH 2/6] MIPS: Loongson32: workaround di issue
Date: Tue, 22 Jan 2019 17:39:36 +0000	[thread overview]
Message-ID: <20190122173934.g4xbqsq43w7hkwy6@pburton-laptop> (raw)
In-Reply-To: <20190122130415.3440-2-jiaxun.yang@flygoat.com>

Hi Jiaxun,

On Tue, Jan 22, 2019 at 09:04:11PM +0800, Jiaxun Yang wrote:
> GS232 core used in Loongson-1 processors has a bug that
> di instruction doesn't save the irqflag immediately.
> 
> Workaround by set irqflag in CP0 before di instructions
> as same as Loongson-3.
> 
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
>  arch/mips/include/asm/irqflags.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/include/asm/irqflags.h b/arch/mips/include/asm/irqflags.h
> index 9d3610be2323..59549d972439 100644
> --- a/arch/mips/include/asm/irqflags.h
> +++ b/arch/mips/include/asm/irqflags.h
> @@ -41,7 +41,7 @@ static inline unsigned long arch_local_irq_save(void)
>  	"	.set	push						\n"
>  	"	.set	reorder						\n"
>  	"	.set	noat						\n"
> -#if defined(CONFIG_CPU_LOONGSON3)
> +#if defined(CONFIG_CPU_LOONGSON3) || defined (CONFIG_CPU_LOONGSON1)
>  	"	mfc0	%[flags], $12					\n"
>  	"	di							\n"
>  #else
> -- 
> 2.20.1

Thanks for your patches.

Since this bug exists on both Loongson 1 CPUs & Loongson 3 CPUs, I'm
wondering whether it also exists on Loongson 2 CPUs. Do you happen to
know whether that is the case?

Thanks,
    Paul

  reply	other threads:[~2019-01-22 17:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-22 13:04 [PATCH 1/6] MIPS: Loongson32: Remove unused platform devices Jiaxun Yang
2019-01-22 13:04 ` [PATCH 2/6] MIPS: Loongson32: workaround di issue Jiaxun Yang
2019-01-22 17:39   ` Paul Burton [this message]
2019-01-23  0:19     ` Jiaxun Yang
2019-01-23  1:34   ` Paul Burton
2019-01-22 13:04 ` [PATCH 3/6] MIPS: Loongson32: Revert ISA level to MIPS32R2 Jiaxun Yang
2019-01-23  1:34   ` Paul Burton
2019-01-22 13:04 ` [PATCH 4/6] MIPS: Loongson32: clarify we don't support MIPS16 and merge configs Jiaxun Yang
2019-01-23  1:34   ` Paul Burton
2019-01-22 13:04 ` [PATCH 5/6] MIPS: Loongson32: Set load address to 0x80200000 Jiaxun Yang
2019-01-23  1:34   ` Paul Burton
2019-01-22 13:04 ` [PATCH 6/6] cpu-probe: Rename Loongson 1B to Loongson GS232 Jiaxun Yang
2019-01-23  1:34 ` [PATCH 1/6] MIPS: Loongson32: Remove unused platform devices Paul Burton
     [not found]   ` <CAJhJPsU1DPBp6it0agNrDfLpQGRV0c45mH6mTi=wcwt0OZikkQ@mail.gmail.com>
2019-01-23  3:40     ` Jiaxun Yang
2019-01-23 21:40       ` Paul Burton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190122173934.g4xbqsq43w7hkwy6@pburton-laptop \
    --to=paul.burton@mips.com \
    --cc=jiaxun.yang@flygoat.com \
    --cc=keguang.zhang@gmail.com \
    --cc=linux-mips@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).