From: Sam Ravnborg <sam@ravnborg.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Sean Paul <sean@poorly.run>,
devicetree@vger.kernel.org, linux-mips@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: Add doc for the ingenic-drm driver
Date: Fri, 1 Mar 2019 21:16:24 +0100 [thread overview]
Message-ID: <20190301201624.GA22317@ravnborg.org> (raw)
In-Reply-To: <20190228220756.20262-2-paul@crapouillou.net>
Hi Paul.
Good to see work migrating fbdev => drm.
Following comments is based on experience while working on migrating
another driver from fbdev => drm.
On Thu, Feb 28, 2019 at 07:07:54PM -0300, Paul Cercueil wrote:
> Add documentation for the devicetree bindings of the DRM driver for the
> JZ47xx family of SoCs from Ingenic.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> Tested-by: Artur Rojek <contact@artur-rojek.eu>
> ---
> .../devicetree/bindings/display/ingenic,drm.txt | 30 ++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/ingenic,drm.txt
>
> diff --git a/Documentation/devicetree/bindings/display/ingenic,drm.txt b/Documentation/devicetree/bindings/display/ingenic,drm.txt
> new file mode 100644
> index 000000000000..52a368ec35cd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/ingenic,drm.txt
> @@ -0,0 +1,30 @@
> +Ingenic JZ47xx DRM driver
> +
> +Required properties:
> +- compatible: one of:
> + * ingenic,jz4740-drm
> + * ingenic,jz4725b-drm
> +- reg: LCD registers location and length
The fbdev way of doing this was to hardcode register setttings.
In the drm world we read the configuration of the panel and let
this decide the actual configuration.
Note that no drm drivers supports stn displays and that there
is really no use for this these days. So you can skip the STN parts.
Also the modern way to specify a panel in the DT is using OF graph bindings.
You can find many examples how to do this.
I was there with the atmel LCDC driver (not in the kernel yet),
and had some challenges with this.
Sam
next prev parent reply other threads:[~2019-03-01 20:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 22:07 [5.2][PATCH 0/3] Ingenic JZ47xx KMS driver Paul Cercueil
2019-02-28 22:07 ` [PATCH 1/3] dt-bindings: Add doc for the ingenic-drm driver Paul Cercueil
2019-03-01 20:16 ` Sam Ravnborg [this message]
2019-03-01 22:40 ` Paul Cercueil
2019-03-08 22:23 ` Linus Walleij
2019-03-09 12:33 ` Paul Cercueil
2019-03-09 0:23 ` Rob Herring
2019-02-28 22:07 ` [PATCH 2/3] dt-bindings: Add header for the ingenic-drm driver bindings Paul Cercueil
2019-02-28 22:07 ` [PATCH 3/3] DRM: Add KMS driver for the Ingenic JZ47xx SoCs Paul Cercueil
2019-03-01 8:26 ` Daniel Vetter
2019-03-01 16:21 ` Paul Cercueil
2019-03-14 12:36 ` Paul Cercueil
2019-03-15 10:53 ` Daniel Vetter
2019-03-01 21:00 ` Sam Ravnborg
2019-03-01 23:33 ` Paul Cercueil
2019-03-11 0:02 ` [5.2][PATCH 0/3] Ingenic JZ47xx KMS driver Ezequiel Garcia
2019-03-11 11:45 ` Paul Cercueil
2019-04-16 14:02 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190301201624.GA22317@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=paul@crapouillou.net \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).