Hi Yifeng, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.0-rc8] [cannot apply to next-20190301] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Yifeng-Li/Preliminary-Platform-Driver-Support-for-Lemote-Yeeloong-Laptops/20190304-005203 config: powerpc-allyesconfig (attached as .config) compiler: powerpc64-linux-gnu-gcc (Debian 8.2.0-11) 8.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=8.2.0 make.cross ARCH=powerpc All errors (new ones prefixed by >>): drivers//mfd/yeeloong_kb3310b.c: In function 'kb3310b_read': >> drivers//mfd/yeeloong_kb3310b.c:70:2: error: implicit declaration of function 'outb'; did you mean 'mftb'? [-Werror=implicit-function-declaration] outb((reg & 0xff00) >> 8, KB3310B_IO_PORT_HIGH); ^~~~ mftb drivers//mfd/yeeloong_kb3310b.c:72:8: error: implicit declaration of function 'inb' [-Werror=implicit-function-declaration] val = inb(KB3310B_IO_PORT_DATA); ^~~ cc1: some warnings being treated as errors vim +70 drivers//mfd/yeeloong_kb3310b.c 62 63 u8 kb3310b_read(u16 reg) 64 { 65 unsigned long flags; 66 u8 val; 67 68 spin_lock_irqsave(&kb3310b_index_lock, flags); 69 > 70 outb((reg & 0xff00) >> 8, KB3310B_IO_PORT_HIGH); 71 outb((reg & 0x00ff), KB3310B_IO_PORT_LOW); 72 val = inb(KB3310B_IO_PORT_DATA); 73 74 spin_unlock_irqrestore(&kb3310b_index_lock, flags); 75 76 return val; 77 } 78 EXPORT_SYMBOL_GPL(kb3310b_read); 79 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation