From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F878C28CC1 for ; Sat, 1 Jun 2019 09:38:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E3AAD271BC for ; Sat, 1 Jun 2019 09:38:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726683AbfFAJih (ORCPT ); Sat, 1 Jun 2019 05:38:37 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:33072 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726109AbfFAJig (ORCPT ); Sat, 1 Jun 2019 05:38:36 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0B916341; Sat, 1 Jun 2019 02:38:36 -0700 (PDT) Received: from arrakis.emea.arm.com (arrakis.cambridge.arm.com [10.1.196.78]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E630B3F5AF; Sat, 1 Jun 2019 02:38:32 -0700 (PDT) Date: Sat, 1 Jun 2019 10:38:30 +0100 From: Catalin Marinas To: Vincenzo Frascino Cc: linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-kselftest@vger.kernel.org, Will Deacon , Arnd Bergmann , Russell King , Ralf Baechle , Paul Burton , Daniel Lezcano , Thomas Gleixner , Mark Salyzyn , Peter Collingbourne , Shuah Khan , Dmitry Safonov <0x7f454c46@gmail.com>, Rasmus Villemoes , Huw Davies Subject: Re: [PATCH v6 15/19] arm64: Add vDSO compat support Message-ID: <20190601093830.GA13589@arrakis.emea.arm.com> References: <20190530141531.43462-1-vincenzo.frascino@arm.com> <20190530141531.43462-16-vincenzo.frascino@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190530141531.43462-16-vincenzo.frascino@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Thu, May 30, 2019 at 03:15:27PM +0100, Vincenzo Frascino wrote: > Add vDSO compat support to the arm64 building system. > > Cc: Catalin Marinas > Cc: Will Deacon > Signed-off-by: Vincenzo Frascino > --- > arch/arm64/Kconfig | 1 + > arch/arm64/Makefile | 23 +++++++++++++++++++++-- > arch/arm64/kernel/Makefile | 6 +++++- > 3 files changed, 27 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 952c9f8cf3b8..3e1d4f8347f4 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -108,6 +108,7 @@ config ARM64 > select GENERIC_STRNLEN_USER > select GENERIC_TIME_VSYSCALL > select GENERIC_GETTIMEOFDAY > + select GENERIC_COMPAT_VDSO if !CPU_BIG_ENDIAN This select needs to also depend on COMPAT (or rather be selected from the COMPAT menuconfig), otherwise, trying to build this series with 64K pages where COMPAT is disabled, I get: VDSOC_GTD arch/arm64/kernel/vdso32/vgettimeofday.o VDSOA arch/arm64/kernel/vdso32/sigreturn.o arch/arm64/kernel/vdso32/sigreturn.S: Assembler messages: arch/arm64/kernel/vdso32/sigreturn.S:25: Error: expected #constant arch/arm64/kernel/vdso32/sigreturn.S:35: Error: expected #constant arch/arm64/kernel/vdso32/sigreturn.S:46: Error: expected #constant arch/arm64/kernel/vdso32/sigreturn.S:56: Error: expected #constant arch/arm64/kernel/vdso32/sigreturn.S:28: Error: undefined symbol __NR_compat_sigreturn used as an immediate value arch/arm64/kernel/vdso32/sigreturn.S:38: Error: undefined symbol __NR_compat_rt_sigreturn used as an immediate value make[2]: *** [arch/arm64/kernel/vdso32/Makefile:154: arch/arm64/kernel/vdso32/sigreturn.o] Error 1 make[2]: *** Waiting for unfinished jobs.... In file included from lib/vdso/gettimeofday.c:25:0, from :0: arch/arm64/include/asm/vdso/compat_gettimeofday.h: In function 'gettimeofday_fallback': arch/arm64/include/asm/vdso/compat_gettimeofday.h:22:31: error: '__NR_compat_gettimeofday' undeclared (first use in this function); did you mean '__NR_gettimeofday'? register long nr asm("r7") = __NR_compat_gettimeofday; ^~~~~~~~~~~~~~~~~~~~~~~~ __NR_gettimeofday arch/arm64/include/asm/vdso/compat_gettimeofday.h:22:31: note: each undeclared identifier is reported only once for each function it appears in arch/arm64/include/asm/vdso/compat_gettimeofday.h: In function 'clock_gettime_fallback': arch/arm64/include/asm/vdso/compat_gettimeofday.h:40:31: error: '__NR_compat_clock_gettime64' undeclared (first use in this function); did you mean '__NR_clock_gettime'? register long nr asm("r7") = __NR_compat_clock_gettime64; ^~~~~~~~~~~~~~~~~~~~~~~~~~~ __NR_clock_gettime arch/arm64/include/asm/vdso/compat_gettimeofday.h: In function 'clock_getres_fallback': arch/arm64/include/asm/vdso/compat_gettimeofday.h:58:31: error: '__NR_compat_clock_getres_time64' undeclared (first use in this function); did you mean '__NR_clock_gettime'? register long nr asm("r7") = __NR_compat_clock_getres_time64; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ __NR_clock_gettime arch/arm64/kernel/vdso32/vgettimeofday.c: In function '__vdso_clock_gettime': arch/arm64/kernel/vdso32/vgettimeofday.c:15:17: error: 'TASK_SIZE_32' undeclared (first use in this function); did you mean 'TASK_SIZE_64'? if ((u32)ts >= TASK_SIZE_32) ^~~~~~~~~~~~ TASK_SIZE_64 arch/arm64/kernel/vdso32/vgettimeofday.c: In function '__vdso_clock_gettime64': arch/arm64/kernel/vdso32/vgettimeofday.c:25:17: error: 'TASK_SIZE_32' undeclared (first use in this function); did you mean 'TASK_SIZE_64'? if ((u32)ts >= TASK_SIZE_32) ^~~~~~~~~~~~ TASK_SIZE_64 arch/arm64/kernel/vdso32/vgettimeofday.c: In function '__vdso_clock_getres': arch/arm64/kernel/vdso32/vgettimeofday.c:41:18: error: 'TASK_SIZE_32' undeclared (first use in this function); did you mean 'TASK_SIZE_64'? if ((u32)res >= TASK_SIZE_32) ^~~~~~~~~~~~ TASK_SIZE_64 make[2]: *** [arch/arm64/kernel/vdso32/Makefile:152: arch/arm64/kernel/vdso32/vgettimeofday.o] Error 1 make[1]: *** [arch/arm64/Makefile:182: vdso_prepare] Error 2 make: *** [Makefile:179: sub-make] Error 2 -- Catalin