From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF989C43613 for ; Fri, 21 Jun 2019 10:49:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B5BEA2084E for ; Fri, 21 Jun 2019 10:49:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=codeweavers.com header.i=@codeweavers.com header.b="EGaACgO9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726250AbfFUKtM (ORCPT ); Fri, 21 Jun 2019 06:49:12 -0400 Received: from mail.codeweavers.com ([50.203.203.244]:48330 "EHLO mail.codeweavers.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726218AbfFUKtM (ORCPT ); Fri, 21 Jun 2019 06:49:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codeweavers.com; s=6377696661; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=j2GzdxnYBK8G7Fj9E5HisiRxVngkkouaD3FQTjun8xw=; b=EGaACgO9PwJhsTSBqdwtLIVr+ NwMW1810knKUDihDGmTj5uZ9ZTEq9zNnCGvyJyYctDTJ2Slu6pp/Wf534Xz+gL3gyQEN0extj+Ix/ sH1jTIrlijGT4xbDNd/9OmdmJKxZqATv/EvWUMPh9BPDt+AiJa9AlPMcdQGghjRVCNwpk=; Received: from merlot.physics.ox.ac.uk ([163.1.241.98] helo=merlot) by mail.codeweavers.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1heH6x-0003kV-6K; Fri, 21 Jun 2019 05:49:40 -0500 Received: from daviesh by merlot with local (Exim 4.90_1) (envelope-from ) id 1heH6M-0001lJ-SR; Fri, 21 Jun 2019 11:49:03 +0100 Date: Fri, 21 Jun 2019 11:49:02 +0100 From: Huw Davies To: Vincenzo Frascino Cc: linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-kselftest@vger.kernel.org, Catalin Marinas , Will Deacon , Arnd Bergmann , Russell King , Ralf Baechle , Paul Burton , Daniel Lezcano , Thomas Gleixner , Mark Salyzyn , Peter Collingbourne , Shuah Khan , Dmitry Safonov <0x7f454c46@gmail.com>, Rasmus Villemoes , Shijith Thotton , Andre Przywara Subject: Re: [PATCH v7 03/25] kernel: Unify update_vsyscall implementation Message-ID: <20190621104902.GA6646@merlot.physics.ox.ac.uk> References: <20190621095252.32307-1-vincenzo.frascino@arm.com> <20190621095252.32307-4-vincenzo.frascino@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190621095252.32307-4-vincenzo.frascino@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Fri, Jun 21, 2019 at 10:52:30AM +0100, Vincenzo Frascino wrote: > diff --git a/kernel/vdso/vsyscall.c b/kernel/vdso/vsyscall.c > new file mode 100644 > index 000000000000..d1e8074e3d10 > --- /dev/null > +++ b/kernel/vdso/vsyscall.c > +static inline void update_vdso_data(struct vdso_data *vdata, > + struct timekeeper *tk) > +{ > + struct vdso_timestamp *vdso_ts; > + u64 nsec; > + > + vdata[CS_HRES_COARSE].cycle_last = tk->tkr_mono.cycle_last; > + vdata[CS_HRES_COARSE].mask = tk->tkr_mono.mask; > + vdata[CS_HRES_COARSE].mult = tk->tkr_mono.mult; > + vdata[CS_HRES_COARSE].shift = tk->tkr_mono.shift; > + vdata[CS_RAW].cycle_last = tk->tkr_raw.cycle_last; > + vdata[CS_RAW].mask = tk->tkr_raw.mask; > + vdata[CS_RAW].mult = tk->tkr_raw.mult; > + vdata[CS_RAW].shift = tk->tkr_raw.shift; > + > + /* CLOCK_REALTIME */ > + vdso_ts = &vdata[CS_HRES_COARSE].basetime[CLOCK_REALTIME]; There's an extraneous space after the '='. Hopefully Thomas can fix this up if this patchset is otherwise ok. > + vdso_ts->sec = tk->xtime_sec; > + vdso_ts->nsec = tk->tkr_mono.xtime_nsec; Huw.