From: Peter Zijlstra <peterz@infradead.org>
To: "huangpei@loongson.cn" <huangpei@loongson.cn>
Cc: 陈华才 <chenhc@lemote.com>, ralf <ralf@linux-mips.org>,
"Paul Burton" <paul.burton@mips.com>, jhogan <jhogan@kernel.org>,
"jiaxun.yang" <jiaxun.yang@flygoat.com>,
linux-mips <linux-mips@vger.kernel.org>
Subject: Re: Something about loongson_llsc_mb
Date: Wed, 4 Sep 2019 11:21:54 +0200 [thread overview]
Message-ID: <20190904092154.GC2349@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <2019090410032559707512@loongson.cn>
*why* are you replying to some random unrelated thread?
Also, please use a sane MUA and wrap your lines <80 chars.
On Wed, Sep 04, 2019 at 10:03:31AM +0800, huangpei@loongson.cn wrote:
> >Hi, Peter,
> >
> >I found that this patch has been merged but I haven't received the e-mail for some unknown reasons.
> >https://git.kernel.org/pub/scm/linux/kernel/git/mips/linux.git/commit/?id=1c6c1ca318585f1096d4d04bc722297c85e9fb8a
> >
> >Firstly, your comments are correct, so the barrier.h part is perfect.
> >
> >Secondly, most of the rest is useless, because smp_mb__before_llsc, loongson_llsc_mb and other memory barriers are the same thing on Loongson-3. We don't need to add loongson_llsc_mb if there is already a smp_mb__before_llsc.
There wasn't. Take for example set_bit(), that didn't have
smp_mb__before_llsc on.
Also; MIPS should probably convert to asm-generic/bitops/atomic.h.
> >Thirdly, maybe the only exception is syscall.c, but mips_atomic_set is not used on Loongson-3. And if in some cases we use it, I think the user-to-kernel context switch has the same effect of a memory barrier.
And how is some random person trying to make sense of MIPS to know that?
You all created a badly documented inconsitent trainwreck. You're
'lucky' the MIPS maintainers accepted that mess in the first place.
Anyway, yes there are too many barrers now in some cases, in a previous
version I had:
https://lkml.kernel.org/r/20190424124421.693353463@infradead.org
But because I dropped changes to local.h that might not be true anymore;
it needs careful consideration. Please audit carefully and if you find
all smp_mb__before_llsc() usage is now superfluous for this 'funny' chip
of yours, then re-submit the above patch.
> +. per-cpu like local_t *should only* be written by local cpu, and may be read by remote cpu sometimes
>
> +. if and only if local cpu can write per-cpu, then Loongson3's llsc bug would not be triggerd.
>
> same as this_cpu_cmpxchg_double
>
> If so, then no need to add sync before and after cmpxchg_local
Correct, we already dropped the change for other local.h stuff.
next prev parent reply other threads:[~2019-09-04 9:22 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-31 5:58 [PATCH v2 0/9] check the node id consistently across different arches Yunsheng Lin
2019-08-31 5:58 ` [PATCH v2 1/9] arm64: numa: check the node id consistently for arm64 Yunsheng Lin
2019-08-31 5:58 ` [PATCH v2 2/9] x86: numa: check the node id consistently for x86 Yunsheng Lin
2019-08-31 8:55 ` Peter Zijlstra
2019-08-31 10:09 ` Yunsheng Lin
2019-08-31 16:12 ` Peter Zijlstra
2019-09-01 4:45 ` Something about loongson_llsc_mb 陈华才
[not found] ` <2019090410032559707512@loongson.cn>
2019-09-04 9:21 ` Peter Zijlstra [this message]
2019-09-04 10:04 ` Peter Zijlstra
2019-09-04 12:57 ` Huang Pei
2019-09-02 5:46 ` [PATCH v2 2/9] x86: numa: check the node id consistently for x86 Yunsheng Lin
2019-09-02 7:25 ` Peter Zijlstra
2019-09-02 12:25 ` Yunsheng Lin
2019-09-02 12:56 ` Peter Zijlstra
2019-09-02 18:22 ` Ingo Molnar
2019-09-02 19:14 ` Peter Zijlstra
2019-09-03 6:19 ` Yunsheng Lin
2019-09-03 7:11 ` Peter Zijlstra
2019-09-03 8:31 ` Yunsheng Lin
2019-09-02 18:17 ` Ingo Molnar
2019-09-03 7:53 ` [PATCH] x86/mm: Fix cpumask_of_node() error condition Peter Zijlstra
2019-08-31 5:58 ` [PATCH v2 3/9] alpha: numa: check the node id consistently for alpha Yunsheng Lin
2019-08-31 5:58 ` [PATCH v2 4/9] powerpc: numa: check the node id consistently for powerpc Yunsheng Lin
2019-08-31 5:58 ` [PATCH v2 5/9] s390: numa: check the node id consistently for s390 Yunsheng Lin
2019-09-02 4:05 ` kbuild test robot
2019-08-31 5:58 ` [PATCH v2 6/9] sh: numa: check the node id consistently for sh Yunsheng Lin
2019-08-31 5:58 ` [PATCH v2 7/9] sparc64: numa: check the node id consistently for sparc64 Yunsheng Lin
2019-08-31 6:53 ` David Miller
2019-08-31 8:57 ` Yunsheng Lin
2019-08-31 20:02 ` David Miller
2019-09-02 6:08 ` Yunsheng Lin
2019-09-02 15:17 ` David Miller
2019-08-31 5:58 ` [PATCH v2 8/9] mips: numa: check the node id consistently for mips ip27 Yunsheng Lin
2019-08-31 5:58 ` [PATCH v2 9/9] mips: numa: check the node id consistently for mips loongson64 Yunsheng Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904092154.GC2349@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=chenhc@lemote.com \
--cc=huangpei@loongson.cn \
--cc=jhogan@kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-mips@vger.kernel.org \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).