From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Paul Cercueil <paul@crapouillou.net>,
Thierry Reding <thierry.reding@gmail.com>,
linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
letux-kernel@openphoenux.org, linux-mips@vger.kernel.org,
tsbogend@alpha.franken.de, stable@vger.kernel.org
Subject: Re: [PATCH] Revert "pwm: jz4740: Enhance precision in calculation of duty cycle"
Date: Fri, 10 Jul 2020 12:18:27 +0200 [thread overview]
Message-ID: <20200710101827.rkaxju7msco4mez7@pengutronix.de> (raw)
In-Reply-To: <9335b924318fb36a882d5b46e8e9f2a10bb24daa.1594365885.git.hns@goldelico.com>
[-- Attachment #1: Type: text/plain, Size: 1564 bytes --]
On Fri, Jul 10, 2020 at 09:24:45AM +0200, H. Nikolaus Schaller wrote:
> This reverts commit a6030d71e62d3e0e270bf3b7fb48d32a636732db.
>
> which was applied to v5.4.49. This ends in a compile issue:
>
> CC drivers/pwm/pwm-jz4740.o - due to target missing
> drivers/pwm/pwm-jz4740.c: In function 'jz4740_pwm_apply':
> drivers/pwm/pwm-jz4740.c:111:28: error: 'rate' undeclared (first use in this function)
> tmp = (unsigned long long)rate * state->duty_cycle;
> ^
> drivers/pwm/pwm-jz4740.c:111:28: note: each undeclared identifier is reported only once for each function it appears in
> make[4]: *** [drivers/pwm/pwm-jz4740.o] Error 1
>
> v5.5 and later include the required additional patches to define
> the rate variable.
So 9017dc4fbd59 ("pwm: jz4740: Enhance precision in calculation of duty
cycle") which is in v5.8-rc1 was backported to stable:
v5.4.49 (as commit a6030d71e62d3e0e270bf3b7fb48d32a636732db)
v5.7.5 (as commit e0e71bb7852142a18fb829da419013bb6da9ed3f)
However 9017dc4fbd59 depends on
ce1f9cece057 ("pwm: jz4740: Use clocks from TCU driver")
(which in mainline comes before 9017dc4fbd59 as it's included in
v5.7-rc1).
As ce1f9cece057 was not backported to v5.4.x, this must either be done, or
we need to patch that. Will reply with a suggested change.
In v5.7.x there is no problem.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-07-10 10:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 7:24 [PATCH] Revert "pwm: jz4740: Enhance precision in calculation of duty cycle" H. Nikolaus Schaller
2020-07-10 10:18 ` Uwe Kleine-König [this message]
2020-07-10 10:46 ` H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200710101827.rkaxju7msco4mez7@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=hns@goldelico.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=stable@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).