From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Arnd Bergmann <arnd@arndb.de>,
od@zcrc.me, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] MIPS: Remove legacy MIPS_MACHINE option
Date: Tue, 28 Jul 2020 10:30:16 +0200 [thread overview]
Message-ID: <20200728083016.GB9062@alpha.franken.de> (raw)
In-Reply-To: <20200726165828.55175-2-paul@crapouillou.net>
On Sun, Jul 26, 2020 at 06:58:28PM +0200, Paul Cercueil wrote:
> The CONFIG_MIPS_MACHINE option is dead code that hasn't been used in
> years. The Kconfig option is not selected anywhere, and the
> <asm/mips_machine.h> is not included anywhere either.
>
> To make things worse, for years it co-existed with a separate MIPS
> machine implementation as <asm/machine.h>. The two defined the
> 'mips_machine' structure with different fields, and the 'MIPS_MACHINE'
> macro with different parameters. The two used the same memory area
> (defined by the linker script) to store data, and you could totally use
> the two at the same time for all kinds of funny results.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> arch/mips/Kconfig | 3 --
> arch/mips/include/asm/mips_machine.h | 46 ---------------------
> arch/mips/kernel/Makefile | 1 -
> arch/mips/kernel/mips_machine.c | 62 ----------------------------
> 4 files changed, 112 deletions(-)
> delete mode 100644 arch/mips/include/asm/mips_machine.h
> delete mode 100644 arch/mips/kernel/mips_machine.c
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2020-07-28 8:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-26 16:58 [PATCH 1/2] MIPS: ath79: Remove unused include <asm/mips_machine.h> Paul Cercueil
2020-07-26 16:58 ` [PATCH 2/2] MIPS: Remove legacy MIPS_MACHINE option Paul Cercueil
2020-07-28 8:30 ` Thomas Bogendoerfer [this message]
2020-07-28 8:30 ` [PATCH 1/2] MIPS: ath79: Remove unused include <asm/mips_machine.h> Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728083016.GB9062@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=od@zcrc.me \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).