From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Huacai Chen <chenhuacai@kernel.org>
Cc: Jinyang He <hejinyang@loongson.cn>,
Eric Biederman <ebiederm@xmission.com>,
Dave Young <dyoung@redhat.com>, Baoquan He <bhe@redhat.com>,
Vivek Goyal <vgoyal@redhat.com>,
"open list:MIPS" <linux-mips@vger.kernel.org>,
kexec@lists.infradead.org, Jiaxun Yang <jiaxun.yang@flygoat.com>,
Youling Tang <tangyouling@loongson.cn>
Subject: Re: [PATCH V3] MIPS: Loongson64: Add kexec/kdump support
Date: Thu, 7 Jan 2021 18:26:20 +0100 [thread overview]
Message-ID: <20210107172620.GA13201@alpha.franken.de> (raw)
In-Reply-To: <CAAhV-H4GDxhg1YqWy-g7VuCeE7BZ0ibaVSr1ibzJqXjuaBn3_w@mail.gmail.com>
On Thu, Dec 31, 2020 at 09:23:33AM +0800, Huacai Chen wrote:
> > Thanks, :-)
> > Jinyang
> Any comments?
sure...
> > > --- a/arch/mips/kernel/relocate_kernel.S
> > > +++ b/arch/mips/kernel/relocate_kernel.S
> > > @@ -6,6 +6,7 @@
> > >
> > > #include <asm/asm.h>
> > > #include <asm/asmmacro.h>
> > > +#include <asm/cpu.h>
> > > #include <asm/regdef.h>
> > > #include <asm/mipsregs.h>
> > > #include <asm/stackframe.h>
> > > @@ -133,6 +134,33 @@ LEAF(kexec_smp_wait)
> > > #else
> > > sync
> > > #endif
> > > +
> > > +#ifdef CONFIG_CPU_LOONGSON64
Is there a reason why you can't use the already existing infrastructure
the way cavium-octeon is doing it ? If you can't please explain why
so we can find a way to extend it. But having some sort of poking
loongson registers in generic MIPS code is a non starter.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2021-01-07 17:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 12:02 [PATCH V3] MIPS: Loongson64: Add kexec/kdump support Huacai Chen
2020-12-22 6:41 ` Jinyang He
2020-12-31 1:23 ` Huacai Chen
2021-01-07 17:26 ` Thomas Bogendoerfer [this message]
2021-01-08 10:07 ` Jinyang He
2021-01-08 10:15 ` Jiaxun Yang
2021-01-09 1:36 ` Huacai Chen
2021-01-09 7:38 ` Jiaxun Yang
2021-01-17 4:24 ` Huacai Chen
2021-01-19 21:08 ` Thomas Bogendoerfer
2021-01-20 1:49 ` Jinyang He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210107172620.GA13201@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=bhe@redhat.com \
--cc=chenhuacai@kernel.org \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=hejinyang@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=kexec@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=tangyouling@loongson.cn \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).