From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/9] MIPS: asm: Move strings to .rodata.str section
Date: Mon, 8 Apr 2024 08:48:26 +0200 [thread overview]
Message-ID: <2654580f-aeac-45d9-b838-8d6cf8605bdc@linaro.org> (raw)
In-Reply-To: <20240326-mips_debug_ll-v2-1-b64abc76f2a1@flygoat.com>
On 26/3/24 21:35, Jiaxun Yang wrote:
> Well, they are read only.
>
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
> arch/mips/include/asm/asm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/include/asm/asm.h b/arch/mips/include/asm/asm.h
> index 2e99450f4228..05a158a8920c 100644
> --- a/arch/mips/include/asm/asm.h
> +++ b/arch/mips/include/asm/asm.h
> @@ -94,7 +94,7 @@ symbol: .insn
> symbol = value
>
> #define TEXT(msg) \
> - .pushsection .data; \
> + .pushsection .rodata.str; \
Nitpicking, \ is now misaligned.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> 8: .asciiz msg; \
> .popsection;
>
>
next prev parent reply other threads:[~2024-04-08 6:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 20:35 [PATCH v2 0/9] MIPS: Unify low-level debugging functionalities Jiaxun Yang
2024-03-26 20:35 ` [PATCH v2 1/9] MIPS: asm: Move strings to .rodata.str section Jiaxun Yang
2024-04-08 6:48 ` Philippe Mathieu-Daudé [this message]
2024-03-26 20:35 ` [PATCH v2 2/9] MIPS: debug: Implement low-level debugging functions Jiaxun Yang
2024-04-08 6:48 ` Philippe Mathieu-Daudé
2024-03-26 20:35 ` [PATCH v2 3/9] MIPS: debug: Hook up DEBUG_LL with early printk Jiaxun Yang
2024-04-08 6:46 ` Philippe Mathieu-Daudé
2024-03-26 20:35 ` [PATCH v2 4/9] MIPS: debug: Provide an early exception vector for low-level debugging Jiaxun Yang
2024-03-26 20:35 ` [PATCH v2 5/9] MIPS: debug_ll: Add Kconfig symbols for some 8250 uarts Jiaxun Yang
2024-04-08 6:46 ` Philippe Mathieu-Daudé
2024-03-26 20:35 ` [PATCH v2 6/9] MIPS: debug_ll: Implement support for Alchemy uarts Jiaxun Yang
2024-03-26 20:35 ` [PATCH v2 7/9] MIPS: debug_ll: Implement support for AR933X uarts Jiaxun Yang
2024-03-26 20:35 ` [PATCH v2 8/9] MIPS: zboot: Convert to use debug_ll facilities Jiaxun Yang
2024-04-08 6:50 ` Philippe Mathieu-Daudé
2024-03-26 20:35 ` [PATCH v2 9/9] MIPS: CPS: " Jiaxun Yang
2024-04-08 6:43 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2654580f-aeac-45d9-b838-8d6cf8605bdc@linaro.org \
--to=philmd@linaro.org \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).