From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AD4F58AB6; Tue, 5 Mar 2024 12:55:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.32 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709643306; cv=none; b=XJTUTrFGkaBYG2kD4epP1L+k+lHRP32YG/qDtzDGeaMX3qrL3XeDiBTxHTk3szCX90bZrv6FT84iuiZeAQSgCmcvNVKS3keFhH1Oqm+Vl1mRNjIlE2ljYGEHYlh9CcN+73PW9dzcaBX8npuU3enJFAumu2dSxB6QG+p/zkzikyk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709643306; c=relaxed/simple; bh=emH1T4ln4UNgH1FvQDF0gEv4wLTdY1+KrVbyFUTNXIs=; h=Subject:To:CC:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=fNQ0nGYfNrLvXidigpjWXcnkllgd43COsHnaVFNtG93rqKp/u/Rmp5Lu82TQUPs3Ml9HrS+FamWFzL0D9X6Ns6ePsxmu035AXA8PuOJhNkdz6WTwoNOsLrP+taWM+797EwNIWa3eFK3Jpcm8KcPPc6+AyOktg0DPJqonSiSOq78= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.234]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4TpwW20SkKz1vvwk; Tue, 5 Mar 2024 20:54:22 +0800 (CST) Received: from dggpemm500005.china.huawei.com (unknown [7.185.36.74]) by mail.maildlp.com (Postfix) with ESMTPS id D89411402E1; Tue, 5 Mar 2024 20:55:01 +0800 (CST) Received: from [10.69.30.204] (10.69.30.204) by dggpemm500005.china.huawei.com (7.185.36.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 5 Mar 2024 20:55:01 +0800 Subject: Re: [RFC PATCH net-next v6 03/15] net: page_pool: factor out page_pool recycle check To: Mina Almasry , , , , , , , , , , , , , CC: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Richard Henderson , Ivan Kokshaysky , Matt Turner , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Andreas Larsson , Jesper Dangaard Brouer , Ilias Apalodimas , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Arnd Bergmann , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , David Ahern , Willem de Bruijn , Shuah Khan , Sumit Semwal , =?UTF-8?Q?Christian_K=c3=b6nig?= , Pavel Begunkov , David Wei , Jason Gunthorpe , Shailend Chand , Harshitha Ramamurthy , Shakeel Butt , Jeroen de Borst , Praveen Kaligineedi References: <20240305020153.2787423-1-almasrymina@google.com> <20240305020153.2787423-4-almasrymina@google.com> From: Yunsheng Lin Message-ID: <3732e5ba-9cfb-f6de-09e2-fab4f46a11d8@huawei.com> Date: Tue, 5 Mar 2024 20:55:01 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20240305020153.2787423-4-almasrymina@google.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500005.china.huawei.com (7.185.36.74) On 2024/3/5 10:01, Mina Almasry wrote: > The check is duplicated in 2 places, factor it out into a common helper. Reviewed-by: Yunsheng Lin