From: Florian Fainelli <f.fainelli@gmail.com>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>,
tsbogend@alpha.franken.de, jonas.gorski@gmail.com,
bcm-kernel-feedback-list@broadcom.com,
linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: BCM63xx: fix 6328 boot selection bit
Date: Tue, 26 May 2020 09:15:54 -0700 [thread overview]
Message-ID: <862863b2-d73e-0c48-6503-c912c60c1b94@gmail.com> (raw)
In-Reply-To: <20200526110324.1324754-1-noltari@gmail.com>
On 5/26/2020 4:03 AM, Álvaro Fernández Rojas wrote:
> MISC_STRAP_BUS_BOOT_SEL_SHIFT is 18 according to Broadcom's GPL source code.
>
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
This is correct:
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Fixes: e5766aea5b9b ("MIPS: BCM63XX: Add basic BCM6328 support")
> ---
> arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h b/arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h
> index bc3444cd4ef2..9ceb5e72889f 100644
> --- a/arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h
> +++ b/arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h
> @@ -1367,8 +1367,8 @@
> #define MISC_STRAPBUS_6328_REG 0x240
> #define STRAPBUS_6328_FCVO_SHIFT 7
> #define STRAPBUS_6328_FCVO_MASK (0x1f << STRAPBUS_6328_FCVO_SHIFT)
> -#define STRAPBUS_6328_BOOT_SEL_SERIAL (1 << 28)
> -#define STRAPBUS_6328_BOOT_SEL_NAND (0 << 28)
> +#define STRAPBUS_6328_BOOT_SEL_SERIAL (1 << 18)
> +#define STRAPBUS_6328_BOOT_SEL_NAND (0 << 18)
>
> /*************************************************************************
> * _REG relative to RSET_PCIE
>
--
Florian
next prev parent reply other threads:[~2020-05-26 16:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 11:03 [PATCH] MIPS: BCM63xx: fix 6328 boot selection bit Álvaro Fernández Rojas
2020-05-26 16:15 ` Florian Fainelli [this message]
2020-05-27 11:33 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=862863b2-d73e-0c48-6503-c912c60c1b94@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=jonas.gorski@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=noltari@gmail.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).