From: Marek Vasut <marex@denx.de>
To: Paul Burton <paul.burton@mips.com>
Cc: "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Paul Burton <pburton@wavecomp.com>,
Daniel Jedrychowski <avistel@gmail.com>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
stable <stable@vger.kernel.org>,
Ezequiel Garcia <ezequiel@collabora.com>
Subject: Re: [PATCH] Revert "serial: 8250: Fix clearing FIFOs in RS485 mode again"
Date: Sun, 16 Dec 2018 22:45:23 +0100 [thread overview]
Message-ID: <949fdd3d-535e-d235-f406-d5bde4658c5e@denx.de> (raw)
In-Reply-To: <20181216213133.kwe24pif3v4wcgwp@pburton-laptop>
On 12/16/2018 10:31 PM, Paul Burton wrote:
> Hi Marek,
Hi,
> On Sun, Dec 16, 2018 at 09:32:19PM +0100, Marek Vasut wrote:
>> I am unable to test it on such a short notice as I'm currently ill, so I
>> cannot tell if your change breaks the OMAP3/AM335x boards or not. Given
>> that there are very few CI20 boards in use, I'd like to ask you for some
>> extra time to investigate this on the OMAP3 too.
>
> I'm sorry to hear that you're ill, but your patch is getting awfully
> close to becoming part of a stable kernel release & it causes
> regressions. Even if it didn't break a board I use, I think the patch
> would be broken & risky for the reasons I outlined in my revert's commit
> message.
That's what the incremental releases are for, so that minor problems can
get fixed there. Sure, it's great to have things perfect in the first
release, but if that breaks other systems, too bad.
> Ultimately it's Greg's decision but it sounds like you're asking me to
> say it's OK to break the JZ4780 in a stable kernel with a patch that I
> think would be risky anyway, and I won't do that.
I am saying this revert breaks AM335x, so this is a stalemate. I had a
discussion with Ezequiel (on CC) and he seems to have a different
smaller patch coming for this problem.
[...]
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2018-12-16 21:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 0:41 [PATCH] serial: 8250: Fix clearing FIFOs in RS485 mode again Paul Burton
2018-12-13 0:55 ` Marek Vasut
2018-12-13 1:48 ` Paul Burton
2018-12-13 2:27 ` Marek Vasut
2018-12-13 3:33 ` Paul Burton
2018-12-13 4:18 ` Marek Vasut
2018-12-13 5:11 ` Paul Burton
2018-12-13 14:51 ` Marek Vasut
2018-12-13 17:48 ` Paul Burton
2018-12-16 20:10 ` [PATCH] Revert "serial: 8250: Fix clearing FIFOs in RS485 mode again" Paul Burton
2018-12-16 20:32 ` Marek Vasut
2018-12-16 21:31 ` Paul Burton
2018-12-16 21:45 ` Marek Vasut [this message]
2018-12-16 21:52 ` Ezequiel Garcia
2018-12-16 22:11 ` Marek Vasut
2018-12-16 22:24 ` Paul Burton
2018-12-16 22:28 ` Ezequiel Garcia
2018-12-16 22:35 ` Paul Burton
2018-12-17 15:18 ` Greg Kroah-Hartman
2018-12-17 15:43 ` Marek Vasut
2018-12-17 16:30 ` Ezequiel Garcia
2018-12-17 17:20 ` Marek Vasut
2018-12-19 0:12 ` Marek Vasut
2018-12-16 22:16 ` Paul Burton
2018-12-16 21:08 ` Marek Vasut
2018-12-16 21:39 ` Paul Burton
2018-12-16 22:01 ` Marek Vasut
2018-12-16 22:28 ` Paul Burton
2018-12-21 20:08 ` Marek Vasut
2018-12-21 21:08 ` Paul Burton
2018-12-21 22:02 ` Marek Vasut
2018-12-24 15:43 ` Paul Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=949fdd3d-535e-d235-f406-d5bde4658c5e@denx.de \
--to=marex@denx.de \
--cc=avistel@gmail.com \
--cc=ezequiel@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=paul.burton@mips.com \
--cc=pburton@wavecomp.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).