From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF2F3C3B186 for ; Wed, 12 Feb 2020 08:14:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C7A1620848 for ; Wed, 12 Feb 2020 08:14:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=goldelico.com header.i=@goldelico.com header.b="dCpxMepp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728504AbgBLIOb (ORCPT ); Wed, 12 Feb 2020 03:14:31 -0500 Received: from mo4-p02-ob.smtp.rzone.de ([85.215.255.80]:30830 "EHLO mo4-p02-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728410AbgBLIOb (ORCPT ); Wed, 12 Feb 2020 03:14:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1581495267; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=uw1pmQHS7f3RyDkV/aP+o5WvUTjTvnxcA78I0t7OepI=; b=dCpxMepp3/hSlUL/kAqXltr8hGfNvBa0TyDBs5h2OcqqeJy5ktnqpCgdL7RyRXwTj9 S6b+GDXDdrzqZLQjby7vYx2Jr7IKvgTjR+zvCzMS0vTK85DMUEbJwRyGfv/8xm0gd1Iw Q4QBQYD8K3khPKD8JPp9l50Bs+r1Iswpn3GC13xjARaUN0uigM312xIPxiKq4lFT7C/6 UDP24971KNNygPT8a6jiHFBT8Cfzt8MciZQA4sIwE5bdMTFVeNo/YiJSYk2supB7TSIF uliSMbrpk05fhVvmpW3ZDPqvGBA4+tpuPTGLr2Q/vGnECBtgFHqUHxE1CN2eHscv5sbY DX0w== X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj5Qpw97WFDlSbXAgODw==" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 46.1.12 DYNA|AUTH) with ESMTPSA id U06217w1C8Ds1dj (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Wed, 12 Feb 2020 09:13:54 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [PATCH 03/14] net: davicom: dm9000: allow to pass MAC address through mac_addr module parameter From: "H. Nikolaus Schaller" In-Reply-To: Date: Wed, 12 Feb 2020 09:13:52 +0100 Cc: Andrew Lunn , Paul Cercueil , Paul Boddie , Alex Smith , Rob Herring , Mark Rutland , Ralf Baechle , Paul Burton , James Hogan , David Airlie , Daniel Vetter , "David S. Miller" , Linus Walleij , Andi Kleen , Krzysztof Kozlowski , Geert Uytterhoeven , Miquel Raynal , =?utf-8?Q?Petr_=C5=A0tetiar?= , Richard Fontana , Allison Randal , Stephen Boyd , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-mips@vger.kernel.org, Linux Kernel Mailing List , DRI Development , Linux I2C , netdev , "open list:GPIO SUBSYSTEM" , letux-kernel@openphoenux.org, kernel@pyra-handheld.com Content-Transfer-Encoding: quoted-printable Message-Id: References: <4e11dd4183da55012198824ca7b8933b1eb57e4a.1581457290.git.hns@goldelico.com> <20200211222506.GP19213@lunn.ch> To: Geert Uytterhoeven X-Mailer: Apple Mail (2.3124) Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org > Am 12.02.2020 um 09:07 schrieb Geert Uytterhoeven = : >=20 > On Tue, Feb 11, 2020 at 11:25 PM Andrew Lunn wrote: >> On Tue, Feb 11, 2020 at 10:41:20PM +0100, H. Nikolaus Schaller wrote: >>> This is needed to give the MIPS Ingenic CI20 board a stable MAC = address >>> which can be optionally provided by vendor U-Boot. >>>=20 >>> For get_mac_addr() we use an adapted copy of from ksz884x.c which >>> has very similar functionality. >>>=20 >>> Signed-off-by: H. Nikolaus Schaller >>=20 >> Hi Nikolaus >>=20 >> Please split these patches by subsystem. So this one patch needs to = go >> via netdev. >>=20 >>> +static char *mac_addr =3D ":"; >>> +module_param(mac_addr, charp, 0); >>> +MODULE_PARM_DESC(mac_addr, "MAC address"); >>=20 >> Module parameters are not liked. >>=20 >> Can it be passed via device tree? The driver already has code to get >> it out of the device tree. >=20 > Yep, typically U-Boot adds an appropriate "local-mac-address" property = to the > network device's device node, based on the "ethernet0" alias. >=20 > However, the real clue here may be "vendor U-Boot", i.e. no support = for the > above? Yes. It is a fallback solution like it is implemented for ksz884x.c to = make it work with existing (older) U-Boot installation. Maybe I should better clarify this in the commit message for v2 (which = goes to netdev only). BR and thanks, Nikolaus