From: Huacai Chen <chenhc@lemote.com>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: "open list:MIPS" <linux-mips@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Frank Rowand <frowand.list@gmail.com>,
Paul Burton <paulburton@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Nick Desaulniers <ndesaulniers@google.com>,
devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/5] MIPS: Loongson64: Add ISA node for LS7A PCH
Date: Mon, 20 Jul 2020 18:04:43 +0800 [thread overview]
Message-ID: <CAAhV-H4i52bxu=fnGhZ=OD0HWC9G2MJ-EN-cSzRNA_9GgBmXPg@mail.gmail.com> (raw)
In-Reply-To: <20200720074249.596364-6-jiaxun.yang@flygoat.com>
Hi, Jiaxun,
On Mon, Jul 20, 2020 at 3:48 PM Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:
>
> Although currently we're not enabling any ISA device in devicetree,
> but this node is required to express the ranges of address reserved
> for ISA.
>
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
> arch/mips/boot/dts/loongson/ls7a-pch.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/mips/boot/dts/loongson/ls7a-pch.dtsi b/arch/mips/boot/dts/loongson/ls7a-pch.dtsi
> index 1c286bb8c703..724929ea3f5f 100644
> --- a/arch/mips/boot/dts/loongson/ls7a-pch.dtsi
> +++ b/arch/mips/boot/dts/loongson/ls7a-pch.dtsi
> @@ -19,6 +19,13 @@ pic: interrupt-controller@10000000 {
> #interrupt-cells = <2>;
> };
>
> + isa {
> + compatible = "isa";
> + #address-cells = <2>;
> + #size-cells = <1>;
> + ranges = <1 0 0 0x18000000 0x20000>;
> + };
> +
Maybe it is better to define isa after pci, which keeps the
consistency as rs780e.
Huacai
> pci@1a000000 {
> compatible = "loongson,ls7a-pci";
> device_type = "pci";
> --
> 2.28.0.rc1
>
prev parent reply other threads:[~2020-07-20 10:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 7:42 [PATCH 0/5] MIPS: Loongson64: Process ISA Node in DeviceTree Jiaxun Yang
2020-07-20 7:42 ` [PATCH 1/5] of_address: Add bus type match for pci ranges parser Jiaxun Yang
2020-07-21 0:21 ` Rob Herring
2020-07-20 7:42 ` [PATCH 2/5] MIPS: Loongson64: Process ISA Node in DeviceTree Jiaxun Yang
2020-07-20 10:01 ` Huacai Chen
2020-07-20 10:18 ` Jiaxun Yang
2020-07-20 11:44 ` Huacai Chen
2020-07-20 11:58 ` Jiaxun Yang
2020-07-21 0:27 ` Rob Herring
2020-07-20 7:42 ` [PATCH 3/5] MIPS: Loongson64: Enlarge IO_SPACE_LIMIT Jiaxun Yang
2020-07-20 10:03 ` Huacai Chen
2020-07-20 10:45 ` Arnd Bergmann
2020-07-20 12:04 ` Jiaxun Yang
2020-07-20 12:20 ` Arnd Bergmann
2020-07-20 7:42 ` [PATCH 4/5] MIPS: Loongson64: DTS: Fix ISA range for RS780E PCH Jiaxun Yang
2020-07-20 7:42 ` [PATCH 5/5] MIPS: Loongson64: Add ISA node for LS7A PCH Jiaxun Yang
2020-07-20 10:04 ` Huacai Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAhV-H4i52bxu=fnGhZ=OD0HWC9G2MJ-EN-cSzRNA_9GgBmXPg@mail.gmail.com' \
--to=chenhc@lemote.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=ndesaulniers@google.com \
--cc=paulburton@kernel.org \
--cc=robh+dt@kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).