From: Paul Burton <paul.burton@mips.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Serge Semin <fancer.lancer@gmail.com>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <pburton@wavecomp.com>,
James Hogan <jhogan@kernel.org>,
Atsushi Nemoto <anemo@mba.ocn.ne.jp>,
Mike Rapoport <rppt@linux.ibm.com>,
"Maciej W . Rozycki" <macro@linux-mips.org>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>
Subject: Re: [PATCH] MIPS: TXx9: Fix boot crash in free_initmem()
Date: Thu, 23 May 2019 01:56:41 +0000 [thread overview]
Message-ID: <MWHPR2201MB1277268FA658B58629931DC5C1010@MWHPR2201MB1277.namprd22.prod.outlook.com> (raw)
In-Reply-To: <20190522081535.16583-1-geert@linux-m68k.org>
Hello,
Geert Uytterhoeven wrote:
> On rbtx4927:
>
> BUG: Bad page state in process swapper pfn:00001
> page:804b7820 refcount:0 mapcount:-128 mapping:00000000 index:0x1
> flags: 0x0()
> raw: 00000000 00000100 00000200 00000000 00000001 00000000 ffffff7f 00000000
> page dumped because: nonzero mapcount
> Modules linked in:
> CPU: 0 PID: 1 Comm: swapper Not tainted 5.2.0-rc1-rbtx4927-00468-g3c05ea3d4077b756 #141
> Stack : 00000000 10008400 8040dc4c 87c1b974 8044af63 8040dc4c 00000001 804a3490
> 00000001 81000000 0030f231 80148558 00000003 10008400 87c1dd80 3d0f9a2c
> 00000000 00000000 804b0000 00000000 00000007 00000000 00000081 00000000
> 62722d31 00000080 804b0000 39347874 00000000 804b7820 8040ce18 81000010
> 00000001 00000007 00000001 81000000 00000018 8021de24 00000000 804a0000
> ...
> Call Trace:
> [<8010adec>] show_stack+0x74/0x104
> [<801a5e44>] bad_page+0x130/0x138
> [<801a654c>] free_pcppages_bulk+0x17c/0x3b0
> [<801a789c>] free_unref_page+0x40/0x68
> [<801120f4>] free_init_pages+0xec/0x104
> [<803bdde8>] free_initmem+0x10/0x58
> [<803bdb8c>] kernel_init+0x20/0x100
> [<801057c8>] ret_from_kernel_thread+0x14/0x1c
>
> As of commit b93ddc4f9156205e ("mips: Reserve memory for the kernel
> image resources"), bootmem_init() no longer reserves the memory below
> the kernel, while prom_free_prom_memory() still frees it.
>
> Fix this by reverting commit b6263ff2d6e58cc2 ("MIPS: TXx9: Implement
> prom_free_prom_memory").
>
> Suggested-by: Serge Semin <fancer.lancer@gmail.com>
> Fixes: b93ddc4f9156205e ("mips: Reserve memory for the kernel image resources")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Reviewed-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Applied to mips-fixes.
Thanks,
Paul
[ This message was auto-generated; if you believe anything is incorrect
then please email paul.burton@mips.com to report it. ]
prev parent reply other threads:[~2019-05-23 1:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 8:15 [PATCH] MIPS: TXx9: Fix boot crash in free_initmem() Geert Uytterhoeven
2019-05-22 11:59 ` Atsushi Nemoto
2019-05-22 12:07 ` Maciej W. Rozycki
2019-05-23 1:56 ` Paul Burton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR2201MB1277268FA658B58629931DC5C1010@MWHPR2201MB1277.namprd22.prod.outlook.com \
--to=paul.burton@mips.com \
--cc=anemo@mba.ocn.ne.jp \
--cc=fancer.lancer@gmail.com \
--cc=geert@linux-m68k.org \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=pburton@wavecomp.com \
--cc=ralf@linux-mips.org \
--cc=rppt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).