From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 793F4C31E44 for ; Fri, 14 Jun 2019 12:19:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4F1992173C for ; Fri, 14 Jun 2019 12:19:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727651AbfFNMT2 (ORCPT ); Fri, 14 Jun 2019 08:19:28 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:37725 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727362AbfFNMT2 (ORCPT ); Fri, 14 Jun 2019 08:19:28 -0400 Received: from [5.158.153.52] (helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1hblAz-0002iH-Sb; Fri, 14 Jun 2019 14:19:26 +0200 Date: Fri, 14 Jun 2019 14:19:25 +0200 (CEST) From: Thomas Gleixner To: Vincenzo Frascino cc: linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-kselftest@vger.kernel.org, Catalin Marinas , Will Deacon , Arnd Bergmann , Russell King , Ralf Baechle , Paul Burton , Daniel Lezcano , Mark Salyzyn , Peter Collingbourne , Shuah Khan , Dmitry Safonov <0x7f454c46@gmail.com>, Rasmus Villemoes , Huw Davies Subject: Re: [PATCH v6 03/19] kernel: Unify update_vsyscall implementation In-Reply-To: Message-ID: References: <20190530141531.43462-1-vincenzo.frascino@arm.com> <20190530141531.43462-4-vincenzo.frascino@arm.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Fri, 14 Jun 2019, Vincenzo Frascino wrote: > On 6/14/19 12:10 PM, Thomas Gleixner wrote: > > On Thu, 30 May 2019, Vincenzo Frascino wrote: > >> + > >> + if (__arch_use_vsyscall(vdata)) { > >> + vdata[CS_HRES_COARSE].cycle_last = > >> + tk->tkr_mono.cycle_last; > >> + vdata[CS_HRES_COARSE].mask = > >> + tk->tkr_mono.mask; > >> + vdata[CS_HRES_COARSE].mult = > >> + tk->tkr_mono.mult; > > > > These line breaks make it really hard to read. Can you fold in the patch > > below please? > > > > Thanks for this. I will do it in v7. Talking about v7. I'd like to get this into 5.3. That means you'd have to rebase it on git://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git hyperv-next to avoid the hyperv conflict. I'll sort this out with the hyperv folks how I can get these bits as a base for a tip branch which holds all the vdso pieces. Thanks, tglx