From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-183.mta1.migadu.com (out-183.mta1.migadu.com [95.215.58.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1DC74437F for ; Thu, 11 Apr 2024 18:00:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712858434; cv=none; b=CnDhsDkfM3sNDhhCuECULYzY6t5A8xLtyRwwRB/X/2rC1gK13U7ufgzj09mCCzDh+egK0S4YjzHlu1qiX8kgeOxlqkomVj8b0K+v/lgcPeySiUBm/x2gzDjNBCuo8gA3ADdpB9F5VlmNd0zEq/Lyjm2iidxsTjAeuRtpor4npWU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712858434; c=relaxed/simple; bh=yh/ixDQ5eg6OWrim9+bm1G6d/37CpJ1/QL+beESG4jw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AdfQoAvwlhY3RVuZSstzgOIl+pb/hf5PK/Rde7eS6IDjZF7ugzaMbsQWldq3yoZyKsXeX6aVnBG97E96SvKQVskaboSEdncnL142CIppr7OcA1NlFk3pEWdoxZpLiL3hD3nzNWoz8oQxjLjx+TpjCoqr4O6FMjAZvnsHH9a8cdM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=F6A8Ql6Y; arc=none smtp.client-ip=95.215.58.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="F6A8Ql6Y" Date: Thu, 11 Apr 2024 14:00:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1712858430; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hugd8ugKeGXlWiLmTwUcSwxtoNqEbzFWRyiumV4I0QI=; b=F6A8Ql6YjuHeVhFhvCjRCHtt6+j5Zmavb6rBRVS2UPMjaUzBr8Uy9YMXKrMLS6Bdu93QAe +1JDwGCXhSmYXVX/GYkUtjra2ilUH2ndkI9p7bCt0GDxnXoAiXvPRveKB1Tl7czCP5mSyl LwnxqSrFPBMBfyHHV7aQPCs6G/4zVIs= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, Alexandre Ghiti , Andrew Morton , =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Donald Dutile , Eric Chanudet , Heiko Carstens , Helge Deller , Huacai Chen , Luis Chamberlain , Mark Rutland , Michael Ellerman , Nadav Amit , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Song Liu , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v4 00/15] mm: jit/text allocator Message-ID: References: <20240411160051.2093261-1-rppt@kernel.org> Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240411160051.2093261-1-rppt@kernel.org> X-Migadu-Flow: FLOW_OUT On Thu, Apr 11, 2024 at 07:00:36PM +0300, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > Hi, > > Since v3 I looked into making execmem more of an utility toolbox, as we > discussed at LPC with Mark Rutland, but it was getting more hairier than > having a struct describing architecture constraints and a type identifying > the consumer of execmem. > > And I do think that having the description of architecture constraints for > allocations of executable memory in a single place is better that having it > spread all over the place. > > The patches available via git: > https://git.kernel.org/pub/scm/linux/kernel/git/rppt/linux.git/log/?h=execmem/v4 > > v4 changes: > * rebase on v6.9-rc2 > * rename execmem_params to execmem_info and execmem_arch_params() to > execmem_arch_setup() > * use single execmem_alloc() API instead of execmem_{text,data}_alloc() (Song) > * avoid extra copy of execmem parameters (Rick) > * run execmem_init() as core_initcall() except for the architectures that > may allocated text really early (currently only x86) (Will) > * add acks for some of arm64 and riscv changes, thanks Will and Alexandre > * new commits: > - drop call to kasan_alloc_module_shadow() on arm64 because it's not > needed anymore > - rename MODULE_START to MODULES_VADDR on MIPS > - use CONFIG_EXECMEM instead of CONFIG_MODULES on powerpc as per Christophe: > https://lore.kernel.org/all/79062fa3-3402-47b3-8920-9231ad05e964@csgroup.eu/ > > v3: https://lore.kernel.org/all/20230918072955.2507221-1-rppt@kernel.org > * add type parameter to execmem allocation APIs > * remove BPF dependency on modules > > v2: https://lore.kernel.org/all/20230616085038.4121892-1-rppt@kernel.org > * Separate "module" and "others" allocations with execmem_text_alloc() > and jit_text_alloc() > * Drop ROX entailment on x86 > * Add ack for nios2 changes, thanks Dinh Nguyen > > v1: https://lore.kernel.org/all/20230601101257.530867-1-rppt@kernel.org > > = Cover letter from v1 (sligtly updated) = > > module_alloc() is used everywhere as a mean to allocate memory for code. > > Beside being semantically wrong, this unnecessarily ties all subsystmes > that need to allocate code, such as ftrace, kprobes and BPF to modules and > puts the burden of code allocation to the modules code. > > Several architectures override module_alloc() because of various > constraints where the executable memory can be located and this causes > additional obstacles for improvements of code allocation. > > A centralized infrastructure for code allocation allows allocations of > executable memory as ROX, and future optimizations such as caching large > pages for better iTLB performance and providing sub-page allocations for > users that only need small jit code snippets. > > Rick Edgecombe proposed perm_alloc extension to vmalloc [1] and Song Liu > proposed execmem_alloc [2], but both these approaches were targeting BPF > allocations and lacked the ground work to abstract executable allocations > and split them from the modules core. > > Thomas Gleixner suggested to express module allocation restrictions and > requirements as struct mod_alloc_type_params [3] that would define ranges, > protections and other parameters for different types of allocations used by > modules and following that suggestion Song separated allocations of > different types in modules (commit ac3b43283923 ("module: replace > module_layout with module_memory")) and posted "Type aware module > allocator" set [4]. > > I liked the idea of parametrising code allocation requirements as a > structure, but I believe the original proposal and Song's module allocator > was too module centric, so I came up with these patches. > > This set splits code allocation from modules by introducing execmem_alloc() > and and execmem_free(), APIs, replaces call sites of module_alloc() and > module_memfree() with the new APIs and implements core text and related > allocations in a central place. > > Instead of architecture specific overrides for module_alloc(), the > architectures that require non-default behaviour for text allocation must > fill execmem_info structure and implement execmem_arch_setup() that returns > a pointer to that structure. If an architecture does not implement > execmem_arch_setup(), the defaults compatible with the current > modules::module_alloc() are used. > > Since architectures define different restrictions on placement, > permissions, alignment and other parameters for memory that can be used by > different subsystems that allocate executable memory, execmem APIs > take a type argument, that will be used to identify the calling subsystem > and to allow architectures to define parameters for ranges suitable for that > subsystem. > > The new infrastructure allows decoupling of BPF, kprobes and ftrace from > modules, and most importantly it paves the way for ROX allocations for > executable memory. It looks like you're just doing API cleanup first, then improving the implementation later? Patch set looks nice and clean; previous versions did seem to leak too much arch/module details (or perhaps we were just bikeshedding too much ;) - but the API first approach is nice. Looking forward to seeing this merged.