From: Muchun Song <muchun.song@linux.dev>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Muchun Song <songmuchun@bytedance.com>,
Naoya Horiguchi <naoya.horiguchi@linux.dev>,
Usama Arif <usama.arif@bytedance.com>,
Miaohe Lin <linmiaohe@huawei.com>,
James Houghton <jthoughton@google.com>,
Michal Hocko <mhocko@suse.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] hugetlb: set hugetlb page flag before optimizing vmemmap
Date: Wed, 30 Aug 2023 11:32:27 +0800 [thread overview]
Message-ID: <00753B00-69DB-499E-8BC3-5DF42DC5936B@linux.dev> (raw)
In-Reply-To: <20230829213734.69673-1-mike.kravetz@oracle.com>
> On Aug 30, 2023, at 05:37, Mike Kravetz <mike.kravetz@oracle.com> wrote:
>
> Currently, vmemmap optimization of hugetlb pages is performed before the
> hugetlb flag (previously hugetlb destructor) is set identifying it as a
> hugetlb folio. This means there is a window of time where an ordinary
> folio does not have all associated vmemmap present. The core mm only
> expects vmemmap to be potentially optimized for hugetlb and device dax.
> This can cause problems in code such as memory error handling that may
> want to write to tail struct pages.
>
> There is only one call to perform hugetlb vmemmap optimization today.
> To fix this issue, simply set the hugetlb flag before that call.
>
> There was a similar issue in the free hugetlb path that was previously
> addressed. The two routines that optimize or restore hugetlb vmemmap
> should only be passed hugetlb folios/pages. To catch any callers not
> following this rule, add VM_WARN_ON calls to the routines. In the
> hugetlb free code paths, some calls could be made to restore vmemmap
> after clearing the hugetlb flag. This was 'safe' as in these cases
> vmemmap was already present and the call was a NOOP. However, for
> consistency these calls where eliminated so that we can add the
> VM_WARN_ON checks.
>
> Fixes: f41f2ed43ca5 ("mm: hugetlb: free the vmemmap pages associated with each HugeTLB page")
> Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
Thanks for your fix.
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
prev parent reply other threads:[~2023-08-30 3:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 21:37 [PATCH] hugetlb: set hugetlb page flag before optimizing vmemmap Mike Kravetz
2023-08-30 3:32 ` Muchun Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00753B00-69DB-499E-8BC3-5DF42DC5936B@linux.dev \
--to=muchun.song@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=jthoughton@google.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=naoya.horiguchi@linux.dev \
--cc=songmuchun@bytedance.com \
--cc=usama.arif@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).