From: Vlastimil Babka <vbabka@suse.cz>
To: Michal Hocko <mhocko@suse.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Pavel Tatashin <pasha.tatashin@soleen.com>,
David Hildenbrand <david@redhat.com>,
Oscar Salvador <osalvador@suse.de>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH 6/9] mm, page_alloc: cache pageset high and batch in struct zone
Date: Wed, 7 Oct 2020 00:34:38 +0200 [thread overview]
Message-ID: <017450b3-21b1-a6a0-adea-b0b4fa1870d3@suse.cz> (raw)
In-Reply-To: <20201005132830.GB4555@dhcp22.suse.cz>
On 10/5/20 3:28 PM, Michal Hocko wrote:
> On Tue 22-09-20 16:37:09, Vlastimil Babka wrote:
>> All per-cpu pagesets for a zone use the same high and batch values, that are
>> duplicated there just for performance (locality) reasons. This patch adds the
>> same variables also to struct zone as a shared copy.
>>
>> This will be useful later for making possible to disable pcplists temporarily
>> by setting high value to 0, while remembering the values for restoring them
>> later. But we can also immediately benefit from not updating pagesets of all
>> possible cpus in case the newly recalculated values (after sysctl change or
>> memory online/offline) are actually unchanged from the previous ones.
>
> Advantage of this patch is not really clear from it in isolation. Maybe
> merge it with the patch which uses the duplicated state.
I'm not sure that would help its reviewability? As the patch that uses it is the
last, largest one. And there is already a small advantage right away as
changelog explains.
next prev parent reply other threads:[~2020-10-06 22:34 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 14:37 [PATCH 0/9] disable pcplists during memory offline Vlastimil Babka
2020-09-22 14:37 ` [PATCH 1/9] mm, page_alloc: clean up pageset high and batch update Vlastimil Babka
2020-09-25 10:18 ` David Hildenbrand
2020-10-05 12:03 ` Michal Hocko
2020-09-22 14:37 ` [PATCH 2/9] mm, page_alloc: calculate pageset high and batch once per zone Vlastimil Babka
2020-10-05 12:52 ` Michal Hocko
2020-10-06 22:04 ` Vlastimil Babka
2020-09-22 14:37 ` [PATCH 3/9] mm, page_alloc: remove setup_pageset() Vlastimil Babka
2020-09-25 10:19 ` David Hildenbrand
2020-10-05 12:59 ` Michal Hocko
2020-10-06 22:11 ` Vlastimil Babka
2020-09-22 14:37 ` [PATCH 4/9] mm, page_alloc: simplify pageset_update() Vlastimil Babka
2020-09-25 10:23 ` David Hildenbrand
2020-10-05 13:20 ` Michal Hocko
2020-09-22 14:37 ` [PATCH 5/9] mm, page_alloc: make per_cpu_pageset accessible only after init Vlastimil Babka
2020-09-25 10:25 ` David Hildenbrand
2020-10-05 13:24 ` Michal Hocko
2020-10-06 22:28 ` Vlastimil Babka
2020-09-22 14:37 ` [PATCH 6/9] mm, page_alloc: cache pageset high and batch in struct zone Vlastimil Babka
2020-09-25 10:34 ` David Hildenbrand
2020-10-06 22:31 ` Vlastimil Babka
2020-10-05 13:28 ` Michal Hocko
2020-10-06 22:34 ` Vlastimil Babka [this message]
2020-09-22 14:37 ` [PATCH 7/9] mm, page_alloc: move draining pcplists to page isolation users Vlastimil Babka
2020-09-25 10:39 ` David Hildenbrand
2020-10-05 13:57 ` Michal Hocko
2020-09-22 14:37 ` [PATCH 8/9] mm, page_alloc: drain all pcplists during memory offline Vlastimil Babka
2020-09-25 10:46 ` David Hildenbrand
2020-10-05 14:03 ` Michal Hocko
2020-09-22 14:37 ` [PATCH 9/9] mm, page_alloc: optionally disable pcplists during page isolation Vlastimil Babka
2020-09-25 10:53 ` David Hildenbrand
2020-09-25 10:54 ` David Hildenbrand
2020-09-25 11:10 ` Vlastimil Babka
2020-10-01 8:47 ` David Hildenbrand
2020-10-05 14:05 ` Michal Hocko
2020-10-05 14:22 ` Vlastimil Babka
2020-10-05 16:56 ` Michal Hocko
2020-10-06 8:34 ` Michal Hocko
2020-10-06 8:40 ` David Hildenbrand
2020-10-06 10:05 ` Michal Hocko
2020-09-22 17:15 ` [PATCH 0/9] disable pcplists during memory offline David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=017450b3-21b1-a6a0-adea-b0b4fa1870d3@suse.cz \
--to=vbabka@suse.cz \
--cc=david@redhat.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=pasha.tatashin@soleen.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).